Allow templating a list for target.device_id#149911
Conversation
![home-assistant[bot]](https://avatars.githubusercontent.com/in/97978?s=60&v=4){kind=small}
There was a problem hiding this comment.
Hello @Ongy,
When attempting to inspect the commits of your pull request for CLA signature status among all authors we encountered commit(s) which were not linked to a GitHub account, thus not allowing us to determine their status(es).
The commits that are missing a linked GitHub account are the following:
faf4f266e1ca7a33d5373edd2957675a8e8bb9b8- This commit has something that looks like an email address (ongy@ongy.net). Maybe try linking that to GitHub?.
Unfortunately, we are unable to accept this pull request until this situation is corrected.
Here are your options:
-
If you had an email address set for the commit that simply wasn't linked to your GitHub account you can link that email now and it will retroactively apply to your commits. The simplest way to do this is to click the link to one of the above commits and look for a blue question mark in a blue circle in the top left. Hovering over that bubble will show you what email address you used. Clicking on that button will take you to your email address settings on GitHub. Just add the email address on that page and you're all set. GitHub has more information about this option in their help center.
-
If you didn't use an email address at all, it was an invalid email, or it's one you can't link to your GitHub, you will need to change the authorship information of the commit and your global Git settings so this doesn't happen again going forward. GitHub provides some great instructions on how to change your authorship information in their help center.
- If you only made a single commit you should be able to run
(substituting "Author Name" and "
git commit --amend --author="Author Name <email@address.com>"email@address.com" for your actual information) to set the authorship information. - If you made more than one commit and the commit with the missing authorship information is not the most recent one you have two options:
- You can re-create all commits missing authorship information. This is going to be the easiest solution for developers that aren't extremely confident in their Git and command line skills.
- You can use this script that GitHub provides to rewrite history. Please note: this should be used only if you are very confident in your abilities and understand its impacts.
- Whichever method you choose, I will come by to re-check the pull request once you push the fixes to this branch.
- If you only made a single commit you should be able to run
We apologize for this inconvenience, especially since it usually bites new contributors to Home Assistant. We hope you understand the need for us to protect ourselves and the great community we all have built legally. The best thing to come out of this is that you only need to fix this once and it benefits the entire Home Assistant and GitHub community.
Thanks, I look forward to checking this PR again soon! ❤️
|
Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍 |
This allows something like:
target:
device_id: '{{ [var1, var2] }}'
Previous code forces the string containing the template to be a (singleton) list of strings.
This only works for simple templates, not for more complex ones.
We don't have type information about the Template render result before it ran
This function is more powerful than necessary and flattes list entries of the target entry lists instead of just unwrapping one list layer.
Ongy
force-pushed
the
allow-lists-in-target-device-id
branch
from
faf4f26 to
8ca50eb
Compare
|
#150239 should solve this problem. |
|
@arturpragacz while you seem to have the same change in, I don't see any tests that validate the new behavior :/ |
|
There hasn't been any activity on this pull request recently. This pull request has been automatically marked as stale because of that and will be closed if no further activity occurs within 7 days. |
|
Not stale, it's waiting for #150239 |
3 participants
Proposed change
Fix the way templates work with service targets.
Currently something like:
Will fail with a type error. This change allows to use templates here.
Without this change, a possible workaround is:
Which is a lot less ergonomic.
I consider this PR mostly an RFC, I think the code sucks, but I can't think of a better way to solve this.
Potentially it might make sense to reduce the power of the normalization and only do it when there's a strict
[[...]]and don't allow for multiple list members to be flattened in a mixed way.Type of change
Additional information
Checklist
ruff format homeassistant tests)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest.requirements_all.txt.Updated by running
python3 -m script.gen_requirements_all.To help with the load of incoming pull requests: