Skip to content

Added HomeKit fan speed#14942

Closed
mlowijs wants to merge 1 commit intohome-assistant:devfrom
mlowijs:dev
Closed

Added HomeKit fan speed#14942
mlowijs wants to merge 1 commit intohome-assistant:devfrom
mlowijs:dev

Conversation

@mlowijs
Copy link
Copy Markdown

@mlowijs mlowijs commented Jun 12, 2018

Description:

Added support for HomeKit fan speed.

I wasn't sure about the cast to string for the fan speed, but it seems fan components hold speed as a string.

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass

@homeassistant
Copy link
Copy Markdown
Contributor

Hi @mlowijs,

It seems you haven't yet signed a CLA. Please do so here.

Once you do that we will be able to review and accept this pull request.

Thanks!

@ghost ghost added the in progress label Jun 12, 2018
@cdce8p cdce8p self-assigned this Jun 12, 2018
@cdce8p
Copy link
Copy Markdown
Member

cdce8p commented Jun 12, 2018

Unfortunately the solution isn't that strait forward. That's the reson why it was excluded from #14351
For more information see: home-assistant/architecture#27

@mlowijs
Copy link
Copy Markdown
Author

mlowijs commented Jun 12, 2018 via email

@cdce8p
Copy link
Copy Markdown
Member

cdce8p commented Jun 12, 2018

In this case sadly no. Nearly every fan platform does it differently, so users will only complain why it doesn't work. We have to fix the speed settings first.

@balloob balloob closed this Jun 13, 2018
@ghost ghost removed the in progress label Jun 13, 2018
@home-assistant home-assistant locked and limited conversation to collaborators Dec 10, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants