Added HomeKit fan speed#14942
Closed
mlowijs wants to merge 1 commit intohome-assistant:devfrom
mlowijs:dev
Closed
Conversation
Contributor
Member
|
Unfortunately the solution isn't that strait forward. That's the reson why it was excluded from #14351 |
Author
|
I understand. It would be nice if we could add this as a stopgap though, some fan speed would be better than no fan speed support at all, no?
… On 12 Jun 2018, at 16:58, cdce8p ***@***.***> wrote:
Unfortunately the solution isn't that strait forward. That's the reson why it was excluded from #14351
For more information see: home-assistant/architecture#27
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or mute the thread.
|
Member
|
In this case sadly no. Nearly every fan platform does it differently, so users will only complain why it doesn't work. We have to fix the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:
Added support for HomeKit fan speed.
I wasn't sure about the cast to string for the fan speed, but it seems fan components hold speed as a string.
Checklist:
tox. Your PR cannot be merged unless tests pass