Skip to content

Add entity registry support to media_player.snapcast#14895

Merged
MartinHjelmare merged 1 commit intohome-assistant:devfrom
jedi7:pr_add_er_snapcast
Jun 10, 2018
Merged

Add entity registry support to media_player.snapcast#14895
MartinHjelmare merged 1 commit intohome-assistant:devfrom
jedi7:pr_add_er_snapcast

Conversation

@jedi7
Copy link
Copy Markdown
Contributor

@jedi7 jedi7 commented Jun 9, 2018

Unique id for client is generated from prefix 'snapcast_client_'
and MAC address

Unique id for group is generated from prefix 'snapcast_group_'
and UUID provided by snapcast library

Description:

Related issue (if applicable): fixes #

Pull request in home-assistant.github.io with documentation (if applicable): home-assistant/home-assistant.github.io#<home-assistant.github.io PR number goes here>

Example entry for configuration.yaml (if applicable):

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • New dependencies have been added to the REQUIREMENTS variable (example).
  • New dependencies are only imported inside functions that use them (example).
  • New or updated dependencies have been added to requirements_all.txt by running script/gen_requirements_all.py.
  • New files were added to .coveragerc.

If the code does not interact with devices:

  • Tests have been added to verify that the new code works.

Unique id for client is generated from prefix 'snapcast_client_'
and MAC address

Unique id for group is generated from prefix 'snapcast_group_'
and UUID provided by snapcast library
@ghost ghost added in progress and removed small-pr PRs with less than 30 lines. labels Jun 9, 2018
Copy link
Copy Markdown
Member

@MartinHjelmare MartinHjelmare left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@MartinHjelmare MartinHjelmare merged commit 20caeb5 into home-assistant:dev Jun 10, 2018
@ghost ghost removed the in progress label Jun 10, 2018
@jedi7 jedi7 deleted the pr_add_er_snapcast branch June 10, 2018 16:41
@balloob balloob mentioned this pull request Jun 22, 2018
@home-assistant home-assistant locked and limited conversation to collaborators Dec 10, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants