Skip to content

Add state trigger to light component#148416

Merged
abmantis merged 47 commits into
dev_target_triggers_conditionsfrom
target_trigger
Sep 18, 2025
Merged

Add state trigger to light component#148416
abmantis merged 47 commits into
dev_target_triggers_conditionsfrom
target_trigger

Conversation

@abmantis
Copy link
Copy Markdown
Member

@abmantis abmantis commented Jul 8, 2025

Proposed change

SSIA.

Requires #148086
Requires #149203

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes Create light trigger #149817
  • This PR is related to issue:
  • Link to documentation pull request:
  • Link to developer documentation pull request:
  • Link to frontend pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Ruff (ruff format homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.

To help with the load of incoming pull requests:

@home-assistant
Copy link
Copy Markdown
Contributor

home-assistant Bot commented Jul 8, 2025

Hey there @home-assistant/core, mind taking a look at this pull request as it has been labeled with an integration (light) you are listed as a code owner for? Thanks!

Code owner commands

Code owners of light can trigger bot actions by commenting:

  • @home-assistant close Closes the pull request.
  • @home-assistant rename Awesome new title Renames the pull request.
  • @home-assistant reopen Reopen the pull request.
  • @home-assistant unassign light Removes the current integration label and assignees on the pull request, add the integration domain after the command.
  • @home-assistant add-label needs-more-information Add a label (needs-more-information, problem in dependency, problem in custom component) to the pull request.
  • @home-assistant remove-label needs-more-information Remove a label (needs-more-information, problem in dependency, problem in custom component) on the pull request.

Base automatically changed from track_entity_changes to dev July 14, 2025 18:28
@abmantis abmantis marked this pull request as ready for review August 7, 2025 16:25
@abmantis abmantis requested a review from a team as a code owner August 7, 2025 16:25
Comment thread homeassistant/components/light/strings.json Outdated
Comment thread tests/components/light/test_trigger.py Outdated
Comment thread tests/components/light/test_trigger.py Outdated
Comment thread tests/components/light/test_trigger.py
@MartinHjelmare MartinHjelmare marked this pull request as draft August 18, 2025 14:54
@arturpragacz
Copy link
Copy Markdown
Member

Before merging this, we should probably address #149817 (comment)

@abmantis abmantis marked this pull request as ready for review September 16, 2025 14:13
Copy link
Copy Markdown
Member

@arturpragacz arturpragacz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good overall, needs to be rebased, other than that just a couple of nitpicks.

Comment thread homeassistant/components/light/trigger.py Outdated
Comment thread homeassistant/components/light/trigger.py
Comment thread homeassistant/components/light/trigger.py
Comment thread homeassistant/components/light/trigger.py Outdated
Comment thread homeassistant/components/light/trigger.py
@abmantis abmantis merged commit e0e263d into dev_target_triggers_conditions Sep 18, 2025
48 checks passed
@abmantis abmantis deleted the target_trigger branch September 18, 2025 18:53
@github-actions github-actions Bot locked and limited conversation to collaborators Sep 19, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Create light trigger

3 participants