Read power state from AVR instead of relying on internal state.#14794
Closed
klada wants to merge 1 commit intohome-assistant:devfrom
Closed
Read power state from AVR instead of relying on internal state.#14794klada wants to merge 1 commit intohome-assistant:devfrom
klada wants to merge 1 commit intohome-assistant:devfrom
Conversation
Contributor
Contributor
|
@klada Actually the power state is red from the device itself. In the denonavr library of scarface-4711 , this update takes place in lines 435 to 461: where the |
Contributor
Author
|
@MartinHjelmare I have a Denon AVR-X6300, which does not call |
Member
|
Will close this PR then, new PR welcome when upstream fixed. |
klada
added a commit
to klada/home-assistant
that referenced
this pull request
Jun 10, 2018
fabaff
pushed a commit
that referenced
this pull request
Jun 10, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:
Right now Home Assistant does not read the power state directly from of a Denon AVR. The power state of the device only gets updated when it is turned on and off through hass. Since the device can also be controlled directly (e.g. through the remote) it would be better to read the power state directly from the device if possible.
Related issue (if applicable):
fixes #14792
Pull request in home-assistant.github.io with documentation (if applicable): home-assistant/home-assistant.github.io#<home-assistant.github.io PR number goes here>
Checklist:
tox. Your PR cannot be merged unless tests pass