Skip to content

Fix media_title empty when title is empty but label is set#14791

Merged
emlove merged 1 commit intohome-assistant:devfrom
quthla:kodi_media_title
Jun 3, 2018
Merged

Fix media_title empty when title is empty but label is set#14791
emlove merged 1 commit intohome-assistant:devfrom
quthla:kodi_media_title

Conversation

@quthla
Copy link
Copy Markdown
Contributor

@quthla quthla commented Jun 3, 2018

Description:

If title was an empy string, fallback to default would never happen.

Related issue (if applicable): fixes #

Pull request in home-assistant.github.io with documentation (if applicable): home-assistant/home-assistant.github.io#<home-assistant.github.io PR number goes here>

Example entry for configuration.yaml (if applicable):

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • New dependencies have been added to the REQUIREMENTS variable (example).
  • New dependencies are only imported inside functions that use them (example).
  • New or updated dependencies have been added to requirements_all.txt by running script/gen_requirements_all.py.
  • New files were added to .coveragerc.

If the code does not interact with devices:

  • Tests have been added to verify that the new code works.

@emlove emlove merged commit e35d4be into home-assistant:dev Jun 3, 2018
@balloob balloob mentioned this pull request Jun 8, 2018
girlpunk pushed a commit to girlpunk/home-assistant that referenced this pull request Sep 4, 2018
@home-assistant home-assistant locked and limited conversation to collaborators Sep 5, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants