Improved Fritz!Box thermostat support

[thomaskr]

• on and off state

• unittests

Description:

The recent version of the Fritz!Box thermostat connector lacks support for on and off mode and reports target temperatures of 126.5 and 127.0 °C with mode manual instead.
This is a result of two special temperature values (253, 254) used by Fritz!Box API. pyfritzbox in between converts them to 126.5 and 127.

I fixed the target temperature display, using 0°C (off) and 30°C (on) instead, added on and off mode and several unit tests.

No configuration changes are required. The changes should be backward compatible but old bad temperature and mode values will remain in history.

Checklist:

• The code change is tested and works locally.
• Local tests pass with tox.

Even without any change tox fails local machine with Ubuntu 18.04 in an unrelated test. Tox runs in Travis CI.

If user exposed functionality or configuration variables are added/changed:

• Documentation added/updated in home-assistant.github.io

If the code communicates with devices, web services, or third-party tools:

• New dependencies have been added to the REQUIREMENTS variable (example).
• New dependencies are only imported inside functions that use them (example).
• New or updated dependencies have been added to requirements_all.txt by running script/gen_requirements_all.py.
• New files were added to .coveragerc.

If the code does not interact with devices:

• Tests have been added to verify that the new code works.

[homeassistant]

Hi @thomaskr,

It seems you haven't yet signed a CLA. Please do so here.

Once you do that we will be able to review and accept this pull request.

Thanks!

[syssi]

Why do you choose 30°C as target temperature for "on"?

[thomaskr]

@syssi Due to how pyfritzbox works internally it had to be a temperature > 28.0°C (the MAX_TEMPERATURE). So, it could also be 28.5 or 29 but smoother values look more comfortable to the user. Pretty much the same applies to the off temperature.
If there is a suitable option in Home Assistant not to present a specific temperature, please point me into the right direction.

[thomaskr]

@syssi I noticed that setting the target_temperature to None will have the right effect.