Skip to content

Add homematicip_cloud illuminance sensor#14720

Merged
MartinHjelmare merged 2 commits intohome-assistant:devfrom
worm-ee:add-homematicip_cloud-illuminance-sensor
Jun 3, 2018
Merged

Add homematicip_cloud illuminance sensor#14720
MartinHjelmare merged 2 commits intohome-assistant:devfrom
worm-ee:add-homematicip_cloud-illuminance-sensor

Conversation

@worm-ee
Copy link
Copy Markdown
Contributor

@worm-ee worm-ee commented May 31, 2018

Description:

  • Add support of illuminate sensors.
  • Add device_class

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass

If the code communicates with devices, web services, or third-party tools:

  • New dependencies have been added to the REQUIREMENTS variable (example).
  • New dependencies are only imported inside functions that use them (example).
  • New dependencies have been added to requirements_all.txt by running script/gen_requirements_all.py.
  • New files were added to .coveragerc.

Copy link
Copy Markdown
Member

@MartinHjelmare MartinHjelmare left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@MartinHjelmare MartinHjelmare merged commit 8f69619 into home-assistant:dev Jun 3, 2018
@balloob balloob mentioned this pull request Jun 8, 2018
@home-assistant home-assistant locked and limited conversation to collaborators Sep 5, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants