WIP: Songpal sound mode support#14718
Closed
rytilahti wants to merge 10 commits intohome-assistant:devfrom
Closed
Conversation
add sound mode support using new denonavr library functions
This is usefull because the sound_mode_raw shows more information than only the sound_mode.
houndci-bot
reviewed
May 31, 2018
| try: | ||
| soundfields = await self.dev.get_soundfield() | ||
| self._soundmodes = {x.value:x.title for x in soundfields.candidate} | ||
| self._active_soundmode = self._soundmodes[soundfields.currentValue] |
There was a problem hiding this comment.
line too long (83 > 79 characters)
|
|
||
| try: | ||
| soundfields = await self.dev.get_soundfield() | ||
| self._soundmodes = {x.value:x.title for x in soundfields.candidate} |
There was a problem hiding this comment.
missing whitespace after ':'
line too long (83 > 79 characters)
| self._sources = inputs | ||
|
|
||
|
|
||
| try: |
| """Return device specific state attributes.""" | ||
| attributes = {} | ||
| if self._sound_mode_raw is not None and self._sound_mode_support\ | ||
| and self._power == 'ON': |
There was a problem hiding this comment.
continuation line over-indented for visual indent
8 tasks
ghost
added
integration: denonavr
integration: songpal
and removed
platform: media_player.denonavr
labels
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:
Implement sound mode support for songpal
Related issue (if applicable): fixes #
Pull request in home-assistant.github.io with documentation (if applicable): home-assistant/home-assistant.github.io#<home-assistant.github.io PR number goes here>
Example entry for
configuration.yaml(if applicable):Checklist:
tox. Your PR cannot be merged unless tests passIf user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
REQUIREMENTSvariable (example).requirements_all.txtby runningscript/gen_requirements_all.py..coveragerc.If the code does not interact with devices: