Add Hanna integration#147085
Conversation
There was a problem hiding this comment.
Hi @bestycame
It seems you haven't yet signed a CLA. Please do so here.
Once you do that we will be able to review and accept this pull request.
Thanks!
NoRi2909
left a comment
There was a problem hiding this comment.
Note from a translator's perspective:
There are a bunch of common strings available which streamline consistent translations quite a bit.
Co-authored-by: Norbert Rittel <norbert@rittel.de>
Co-authored-by: Norbert Rittel <norbert@rittel.de>
Co-authored-by: Norbert Rittel <norbert@rittel.de>
Thank you for your excellent suggestion! |
|
One more thing, which I seem to have missed: The linked homepage on PyPi is a 404. |
Updated the URL on the package :)
|
|
(Close + reopen to rerun CI) |
joostlek
left a comment
There was a problem hiding this comment.
I would be really cool if we could add example data in the PR so we could add sensor tests
joostlek
left a comment
There was a problem hiding this comment.
Mind sending me a message on discord?
| "name": "Chlorine ORP value" | ||
| }, | ||
| "ph_acid_base_flow_rate": { | ||
| "name": "pH Acid/Base flow rate" |
There was a problem hiding this comment.
I only noticed this one post-merge in Lokalise:
It looks like "acid/base" should not be capitalized as we should translate those.
For proper translation: This is the flow rate of an acid or base that is added to correct the pH walue?
Proposed change
This PR intends to create a new integration called
Hanna.The Integration will connect to Hanna Cloud from Hanna Instruments in order to integrate a compatible Pool Controller.
Type of change
Additional information
Checklist
ruff format homeassistant tests)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest.requirements_all.txt.Updated by running
python3 -m script.gen_requirements_all.To help with the load of incoming pull requests: