Skip to content

Add Hanna integration#147085

Merged
joostlek merged 32 commits into
home-assistant:devfrom
bestycame:add_hanna_integration
Nov 20, 2025
Merged

Add Hanna integration#147085
joostlek merged 32 commits into
home-assistant:devfrom
bestycame:add_hanna_integration

Conversation

@bestycame
Copy link
Copy Markdown
Contributor

@bestycame bestycame commented Jun 18, 2025

Proposed change

This PR intends to create a new integration called Hanna.
The Integration will connect to Hanna Cloud from Hanna Instruments in order to integrate a compatible Pool Controller.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: Not Applicable
  • This PR is related to issue: Not Applicable
  • Link to documentation pull request: PR 39617
  • Link to developer documentation pull request: Not Applicable
  • Link to frontend pull request: Not Applicable

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Ruff (ruff format homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.

To help with the load of incoming pull requests:

Copy link
Copy Markdown
Contributor

@home-assistant home-assistant Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @bestycame

It seems you haven't yet signed a CLA. Please do so here.

Once you do that we will be able to review and accept this pull request.

Thanks!

@bestycame bestycame marked this pull request as ready for review June 18, 2025 11:50
@bestycame bestycame marked this pull request as draft June 18, 2025 11:54
@bestycame bestycame marked this pull request as ready for review June 18, 2025 11:54
Copy link
Copy Markdown
Contributor

@NoRi2909 NoRi2909 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note from a translator's perspective:

There are a bunch of common strings available which streamline consistent translations quite a bit.

Comment thread homeassistant/components/hanna/strings.json Outdated
Comment thread homeassistant/components/hanna/strings.json Outdated
Comment thread homeassistant/components/hanna/strings.json Outdated
bestycame and others added 3 commits June 18, 2025 15:19
Co-authored-by: Norbert Rittel <norbert@rittel.de>
Co-authored-by: Norbert Rittel <norbert@rittel.de>
Co-authored-by: Norbert Rittel <norbert@rittel.de>
@bestycame
Copy link
Copy Markdown
Contributor Author

Note from a translator's perspective:

There are a bunch of common strings available which streamline consistent translations quite a bit.

Thank you for your excellent suggestion!
Changes commited.

@bestycame bestycame requested a review from NoRi2909 June 19, 2025 10:36
@bestycame bestycame marked this pull request as draft June 19, 2025 10:48
@bestycame bestycame marked this pull request as ready for review June 19, 2025 11:12
@bestycame bestycame marked this pull request as ready for review October 16, 2025 13:06
@home-assistant home-assistant Bot requested a review from emontnemery October 16, 2025 13:06
Comment thread tests/components/hanna/test_config_flow.py Outdated
@home-assistant home-assistant Bot marked this pull request as draft October 16, 2025 13:42
@emontnemery
Copy link
Copy Markdown
Contributor

One more thing, which I seem to have missed:
Does the hanna-cloud PyPi package meet our transparency requirements?

The linked homepage on PyPi is a 404.

@bestycame
Copy link
Copy Markdown
Contributor Author

bestycame commented Oct 16, 2025

One more thing, which I seem to have missed: Does the hanna-cloud PyPi package meet our transparency requirements?

The linked homepage on PyPi is a 404.

Updated the URL on the package :)

  • The source code of the dependency must be available under an OSI-approved license.
  • The dependency must be available on PyPI.
  • The package published to PyPI should be built in and published from a public CI pipeline.
  • The version of the dependency published on PyPI should correspond to a tagged release in an open online repository.
    • Yes: Package 0.0.6 has fixed the URL in the package's setup.py file. Requirement in the Hanna integration upgraded to use that version.

@bestycame bestycame marked this pull request as ready for review October 16, 2025 15:42
@bestycame bestycame requested a review from emontnemery October 16, 2025 15:42
@home-assistant home-assistant Bot requested a review from emontnemery October 16, 2025 15:42
@emontnemery emontnemery reopened this Oct 23, 2025
@emontnemery
Copy link
Copy Markdown
Contributor

(Close + reopen to rerun CI)

Copy link
Copy Markdown
Member

@joostlek joostlek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would be really cool if we could add example data in the PR so we could add sensor tests

Comment thread homeassistant/components/hanna/__init__.py Outdated
Comment thread homeassistant/components/hanna/config_flow.py Outdated
Comment thread homeassistant/components/hanna/manifest.json Outdated
Comment thread homeassistant/components/hanna/coordinator.py Outdated
Comment thread homeassistant/components/hanna/coordinator.py Outdated
Comment thread homeassistant/components/hanna/sensor.py Outdated
Comment thread tests/components/hanna/conftest.py Outdated
Comment thread tests/components/hanna/test_config_flow.py
Comment thread tests/components/hanna/test_config_flow.py Outdated
Comment thread tests/components/hanna/test_config_flow.py
@home-assistant home-assistant Bot marked this pull request as draft October 23, 2025 17:45
@bestycame bestycame marked this pull request as ready for review November 12, 2025 20:25
@home-assistant home-assistant Bot requested a review from joostlek November 12, 2025 20:25
Copy link
Copy Markdown
Member

@joostlek joostlek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mind sending me a message on discord?

@joostlek joostlek merged commit 0a034b9 into home-assistant:dev Nov 20, 2025
67 checks passed
"name": "Chlorine ORP value"
},
"ph_acid_base_flow_rate": {
"name": "pH Acid/Base flow rate"
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I only noticed this one post-merge in Lokalise:
It looks like "acid/base" should not be capitalized as we should translate those.

For proper translation: This is the flow rate of an acid or base that is added to correct the pH walue?

@github-actions github-actions Bot locked and limited conversation to collaborators Nov 21, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants