Fix Eco mode display on Nest#14706
Merged
balloob merged 2 commits intohome-assistant:devfrom May 31, 2018
ciotlosm:fix_eco_nest
Merged
Fix Eco mode display on Nest#14706balloob merged 2 commits intohome-assistant:devfrom ciotlosm:fix_eco_nest
balloob merged 2 commits intohome-assistant:devfrom
ciotlosm:fix_eco_nest
Conversation
homeassistant
added
cla-signed
platform: climate.nest
small-pr
houndci-bot
reviewed
May 30, 2018
| if self._mode != NEST_MODE_HEAT_COOL and not self.is_away_mode_on: | ||
| if self._mode != NEST_MODE_HEAT_COOL and \ | ||
| self._mode != STATE_ECO and \ | ||
| not self.is_away_mode_on: |
There was a problem hiding this comment.
continuation line over-indented for visual indent
| """Return the temperature we try to reach.""" | ||
| if self._mode != NEST_MODE_HEAT_COOL and not self.is_away_mode_on: | ||
| if self._mode != NEST_MODE_HEAT_COOL and \ | ||
| self._mode != STATE_ECO and \ |
There was a problem hiding this comment.
continuation line over-indented for visual indent
balloob
pushed a commit
that referenced
this pull request
May 31, 2018
* Fix Eco mode display on Nest * Fix Hound problems
Merged
PhilRW
pushed a commit
to PhilRW/home-assistant
that referenced
this pull request
Jun 1, 2018
* Fix Eco mode display on Nest * Fix Hound problems
girlpunk
pushed a commit
to girlpunk/home-assistant
that referenced
this pull request
Sep 4, 2018
* Fix Eco mode display on Nest * Fix Hound problems
ghost
added
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:
Related issue (if applicable): fixes #12707
Pull request in home-assistant.github.io with documentation (if applicable): N/A
Example entry for
configuration.yaml(if applicable):no changesChecklist: