Skip to content

Ignore unsupported Sonos favorite lists #14665

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
MartinHjelmare merged 1 commit into from
May 29, 2018
Merged

Ignore unsupported Sonos favorite lists #14665

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 12 additions & 9 deletions homeassistant/components/media_player/sonos.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -427,15 +427,18 @@ def _set_basic_information(self):
self.update_volume()

self._favorites = []
for fav in self.soco.music_library.get_sonos_favorites():
# SoCo 0.14 raises a generic Exception on invalid xml in favorites.
# Filter those out now so our list is safe to use.
try:
if fav.reference.get_uri():
self._favorites.append(fav)
# pylint: disable=broad-except
except Exception:
_LOGGER.debug("Ignoring invalid favorite '%s'", fav.title)
# SoCo 0.14 raises a generic Exception on invalid xml in favorites.
# Filter those out now so our list is safe to use.
# pylint: disable=broad-except
try:
for fav in self.soco.music_library.get_sonos_favorites():
try:
if fav.reference.get_uri():
self._favorites.append(fav)
except Exception:
_LOGGER.debug("Ignoring invalid favorite '%s'", fav.title)
except Exception:
_LOGGER.debug("Ignoring invalid favorite list")

def _radio_artwork(self, url):
"""Return the private URL with artwork for a radio stream."""
Expand Down