Improve Homekit media_player options#14637
Merged
balloob merged 5 commits intohome-assistant:devfrom May 28, 2018
cdce8p:homekit-entity_config-features
Merged
Improve Homekit media_player options#14637balloob merged 5 commits intohome-assistant:devfrom cdce8p:homekit-entity_config-features
balloob merged 5 commits intohome-assistant:devfrom
cdce8p:homekit-entity_config-features
Conversation
2 tasks
balloob
approved these changes
May 28, 2018
Merged
girlpunk
pushed a commit
to girlpunk/home-assistant
that referenced
this pull request
Sep 4, 2018
* Optimize imports * Optimize name * Optimize config schema * Rename mode to feature * Replace mode with feature_list
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:
The goal of this PR is to replace the
entity_configmodeoption formedia_playerentities with thefeature_list. Since themedia_player#14446 isn't yet merged intorcormasterthis would not technical be a breaking change. Using the proposed config allows for more flexibility down the road, has more resemblance to theplatformconfig logic and thus will probably be a bit easier to understand.The config change aside,
homekitwill not add all supportedfeaturesformedia_playersanymore by default, since in most cases added four separate switches foron / off,play / pause,play / stop,mute / unmuteinsn't desired.Pull request in home-assistant.github.io with documentation (if applicable): home-assistant/home-assistant.io#5447
Example entry for
configuration.yaml(if applicable):Checklist:
tox. Your PR cannot be merged unless tests passCC: @schmittx