Skip to content

Add HomeKit support for automations #14595

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
cdce8p merged 2 commits into from
May 25, 2018
Merged

Add HomeKit support for automations #14595

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
58d6462
Initial commit
schmittx May 23, 2018
29705da
Small test change
cdce8p May 23, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion homeassistant/components/homekit/__init__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -143,7 +143,8 @@ def get_accessory(hass, state, aid, config):
elif device_class == DEVICE_CLASS_ILLUMINANCE or unit in ('lm', 'lx'):
a_type = 'LightSensor'

elif state.domain in ('switch', 'remote', 'input_boolean', 'script'):
elif state.domain in ('automation', 'input_boolean', 'remote', 'script',
'switch'):
a_type = 'Switch'

if a_type is None:
Expand Down
6 changes: 4 additions & 2 deletions tests/components/homekit/test_get_accessories.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -109,9 +109,11 @@ def test_type_sensors(type_name, entity_id, state, attrs):


@pytest.mark.parametrize('type_name, entity_id, state, attrs', [
('Switch', 'switch.test', 'on', {}),
('Switch', 'remote.test', 'on', {}),
('Switch', 'automation.test', 'on', {}),
('Switch', 'input_boolean.test', 'on', {}),
('Switch', 'remote.test', 'on', {}),
('Switch', 'script.test', 'on', {}),
('Switch', 'switch.test', 'on', {}),
])
def test_type_switches(type_name, entity_id, state, attrs):
"""Test if switch types are associated correctly."""
Expand Down
7 changes: 6 additions & 1 deletion tests/components/homekit/test_type_switches.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,12 @@


@pytest.mark.parametrize('entity_id', [
'switch.test', 'remote.test', 'input_boolean.test'])
'automation.test',
'input_boolean.test',
'remote.test',
'script.test',
'switch.test',
])
async def test_switch_set_state(hass, entity_id):
"""Test if accessory and HA are updated accordingly."""
domain = split_entity_id(entity_id)[0]
Expand Down