Skip to content

Adding motion sensor#14585

Closed
alandtse wants to merge 1 commit intohome-assistant:devfrom
alandtse:doorbird
Closed

Adding motion sensor#14585
alandtse wants to merge 1 commit intohome-assistant:devfrom
alandtse:doorbird

Conversation

@alandtse
Copy link
Copy Markdown
Contributor

@alandtse alandtse commented May 22, 2018

Description:

Adds a motion sensor event

Related issue (if applicable): fixes #

Pull request in home-assistant.github.io with documentation (if applicable): home-assistant/home-assistant.io#5414

Example entry for configuration.yaml (if applicable):

doorbird:
  host: DOORBIRD_IP
  username: !secret doorbird_user
  password: !secret doorbird_password
  doorbell_events: true
  motion_events: true
  hass_url_override: https://HASS_IP:8123

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • New dependencies have been added to the REQUIREMENTS variable (example).
  • New dependencies are only imported inside functions that use them (example).
  • New dependencies have been added to requirements_all.txt by running script/gen_requirements_all.py.
  • New files were added to .coveragerc.

If the code does not interact with devices:

  • Tests have been added to verify that the new code works.

@syssi
Copy link
Copy Markdown
Member

syssi commented May 22, 2018

Please have a look at #13994. Is this a duplicate?

@alandtse
Copy link
Copy Markdown
Contributor Author

@syssi Well dang. Yes it is. Closing this.

@alandtse alandtse closed this May 22, 2018
@home-assistant home-assistant locked and limited conversation to collaborators Sep 5, 2018
@alandtse alandtse deleted the doorbird branch October 20, 2019 07:41
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants