fix nanoleaf aurora lights min and max temperature#14571
Merged
balloob merged 2 commits intohome-assistant:devfrom May 21, 2018
Merged
fix nanoleaf aurora lights min and max temperature#14571balloob merged 2 commits intohome-assistant:devfrom
balloob merged 2 commits intohome-assistant:devfrom
Conversation
homeassistant
added
cla-signed
platform: light.nanoleaf_aurora
small-pr
syssi
reviewed
May 21, 2018
| CONFIG_FILE = '.nanoleaf_aurora.conf' | ||
|
|
||
| NANOLEAF_AURORA_MIN_MIRED = 154 | ||
| NANOLEAF_AURORA_MAX_MIRED = 833 |
Member
There was a problem hiding this comment.
The name of the const is a bit verbose and is used only once. In my opinion you could put the values direct to the methods.
syssi
approved these changes
May 21, 2018
balloob
pushed a commit
that referenced
this pull request
May 21, 2018
* fixed nanoleaf aurora lights min and max temperature * review changes
Merged
ghost
added
integration: nanoleaf_aurora
and removed
platform: light.nanoleaf_aurora
labels
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:
Setting Nanoleaf Aurora light panels to min temperature did not work and the max temperature was not the actual max
Related issue (if applicable): none
Pull request in home-assistant.github.io with documentation (if applicable): none
Example entry for
configuration.yaml(if applicable): noneChecklist:
tox. Your PR cannot be merged unless tests pass