Homekit style cleanup#14556
Merged
balloob merged 3 commits intohome-assistant:devfrom May 21, 2018
cdce8p:homekit-style-cleanup
Merged
Homekit style cleanup#14556balloob merged 3 commits intohome-assistant:devfrom cdce8p:homekit-style-cleanup
balloob merged 3 commits intohome-assistant:devfrom
cdce8p:homekit-style-cleanup
Conversation
* Sorted imports * Harmonized service calls
2 tasks
4 tasks
balloob
approved these changes
May 21, 2018
balloob
pushed a commit
that referenced
this pull request
May 21, 2018
* Style cleanup * Sorted imports * Harmonized service calls * Test improvements * Small update
Merged
girlpunk
pushed a commit
to girlpunk/home-assistant
that referenced
this pull request
Sep 4, 2018
* Style cleanup * Sorted imports * Harmonized service calls * Test improvements * Small update
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:
A bit of cleanup for the
HomeKitcomponent.Changes
HomeAccessory.update_state()now raises aNotImplementedErrorto make sure it's overridden for each type.HomeAccessory.update_state_callback()is now a callback and invokesupdate_state()throughself.hass.async_add_job(). difftypesnow use the same structure.Checklist:
tox. Your PR cannot be merged unless tests pass