Skip to content

Add quality scale for Sonos#144928

Merged
joostlek merged 9 commits into
home-assistant:devfrom
PeteRager:sonos-quality-scale
Aug 11, 2025
Merged

Add quality scale for Sonos#144928
joostlek merged 9 commits into
home-assistant:devfrom
PeteRager:sonos-quality-scale

Conversation

@PeteRager
Copy link
Copy Markdown
Contributor

Proposed change

Add quality_scale.yaml for Sonos to assess current state (not bronze.) And to help prioritize work to get it to bronze.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:
  • Link to developer documentation pull request:
  • Link to frontend pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Ruff (ruff format homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.

To help with the load of incoming pull requests:

@home-assistant
Copy link
Copy Markdown
Contributor

Hey there @jjlawren, mind taking a look at this pull request as it has been labeled with an integration (sonos) you are listed as a code owner for? Thanks!

Code owner commands

Code owners of sonos can trigger bot actions by commenting:

  • @home-assistant close Closes the pull request.
  • @home-assistant rename Awesome new title Renames the pull request.
  • @home-assistant reopen Reopen the pull request.
  • @home-assistant unassign sonos Removes the current integration label and assignees on the pull request, add the integration domain after the command.
  • @home-assistant add-label needs-more-information Add a label (needs-more-information, problem in dependency, problem in custom component) to the pull request.
  • @home-assistant remove-label needs-more-information Remove a label (needs-more-information, problem in dependency, problem in custom component) on the pull request.

Copy link
Copy Markdown
Member

@joostlek joostlek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's add the things we agree on to the comments and get this merged and improve from there

Comment thread homeassistant/components/sonos/quality_scale.yaml
Comment thread homeassistant/components/sonos/quality_scale.yaml
Comment thread homeassistant/components/sonos/quality_scale.yaml
Comment thread homeassistant/components/sonos/quality_scale.yaml
Comment thread homeassistant/components/sonos/quality_scale.yaml
Comment thread homeassistant/components/sonos/quality_scale.yaml Outdated
status: exempt
comment: |
No authentication
test-coverage: todo
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some tests are using internals

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes. That needs to be fixed.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

for test_init.py - #147063

Comment thread homeassistant/components/sonos/quality_scale.yaml Outdated
status: exempt
comment: |
No authentication
test-coverage: todo
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

test_play_media_library ideally we don't have if statements in the tests

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

agree

status: exempt
comment: |
No authentication
test-coverage: todo
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For some reason test_sensor is testing both binary sensor and sensor

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we can break it apart

@home-assistant
Copy link
Copy Markdown
Contributor

Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍

Learn more about our pull request process.

@PeteRager PeteRager marked this pull request as ready for review June 26, 2025 21:00
@home-assistant home-assistant Bot requested a review from joostlek June 26, 2025 21:00
@frenck frenck requested a review from Copilot June 26, 2025 21:24
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR introduces a quality scale definition for the Sonos integration and enables hassfest checks by removing it from the skip list.

  • Removed sonos from the skip list in script/hassfest/quality_scale.py
  • Added quality_scale.yaml under homeassistant/components/sonos/ with rule statuses and exemptions

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File Description
script/hassfest/quality_scale.py Removed "sonos" from the skip list
homeassistant/components/sonos/quality_scale.yaml Added Sonos quality_scale.yaml with rules
Comments suppressed due to low confidence (1)

homeassistant/components/sonos/quality_scale.yaml:73

  • [nitpick] Add a blank line before the # Platinum section header to visually separate it from the Gold section and improve readability.
  # Platinum

@joostlek joostlek merged commit 6e3ccbe into home-assistant:dev Aug 11, 2025
34 checks passed
@github-actions github-actions Bot locked and limited conversation to collaborators Aug 12, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants