Skip to content

Bump lakeside version#14471

Merged
fabaff merged 1 commit into
home-assistant:devfrom
mjg59:eufy
May 15, 2018
Merged

Bump lakeside version#14471
fabaff merged 1 commit into
home-assistant:devfrom
mjg59:eufy

Conversation

@mjg59
Copy link
Copy Markdown
Contributor

@mjg59 mjg59 commented May 15, 2018

This should fix a couple of issues with T1013 bulbs, and also handle
accounts that contain unknown devices.

Related issue (if applicable): fixes #14158

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • New dependencies have been added to the REQUIREMENTS variable (example).
  • New dependencies are only imported inside functions that use them (example).
  • New dependencies have been added to requirements_all.txt by running script/gen_requirements_all.py.
  • New files were added to .coveragerc.

If the code does not interact with devices:

  • Tests have been added to verify that the new code works.

This should fix a couple of issues with T1013 bulbs, and also handle
accounts that contain unknown devices.
Copy link
Copy Markdown
Member

@fabaff fabaff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 🐦

@fabaff fabaff merged commit 11c57f9 into home-assistant:dev May 15, 2018
@balloob balloob mentioned this pull request May 28, 2018
girlpunk pushed a commit to girlpunk/home-assistant that referenced this pull request Sep 4, 2018
This should fix a couple of issues with T1013 bulbs, and also handle
accounts that contain unknown devices.
@home-assistant home-assistant locked and limited conversation to collaborators Sep 5, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Bug in Google's lakeside library

3 participants