"unavailable" Media players should be considered off in Universal player#14466
Merged
syssi merged 1 commit intoMay 16, 2018
Merged
Conversation
The Universal media player inherits the states of the first child player that is not in some sort of "Off" state (including idle.) It was not considering the "unavailable" state to be off. Now it does.
homeassistant
added
platform: media_player.universal
small-pr
Member
|
Which media player (mediaroom, soundtouch?) returns the "unavailable" state? |
Contributor
Author
|
The only one I know about is Plex returns the unavailable state when a Plex client goes offline (and is therefore uncontrollable). The behavior is defined all the way up in Entity, though - if any entity sets its |
syssi
approved these changes
May 15, 2018
Merged
girlpunk
pushed a commit
to girlpunk/home-assistant
that referenced
this pull request
Sep 4, 2018
…yer (home-assistant#14466) The Universal media player inherits the states of the first child player that is not in some sort of "Off" state (including idle.) It was not considering the "unavailable" state to be off. Now it does.
ghost
added
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:
The Universal media player inherits the states of the first child player that is not in some sort of "Off" state (including idle.) It was not considering the "unavailable" state to be off. Now it does.
Related issue (if applicable): n/a
Pull request in home-assistant.github.io with documentation (if applicable): n/a
Checklist:
tox. Your PR cannot be merged unless tests pass