Skip to content

Add stdout and stderr to debug output for shell_command#14465

Merged
pvizeli merged 1 commit into
home-assistant:devfrom
n8henrie:shellcommand_logging
May 16, 2018
Merged

Add stdout and stderr to debug output for shell_command#14465
pvizeli merged 1 commit into
home-assistant:devfrom
n8henrie:shellcommand_logging

Conversation

@n8henrie
Copy link
Copy Markdown
Contributor

Description:

shell_command is much easier to debug if its stdout and stderr are captured and made available in the log. As implemented in this PR, they will only been shown when shell_command logging verbosity is set to debug, allowing users to use that information when needed, but should not clutter the logs by default.

Related issue (if applicable):

Pull request in home-assistant.github.io with documentation (if applicable): home-assistant/home-assistant.github.io#<home-assistant.github.io PR number goes here>

Example entry for configuration.yaml (if applicable):

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • New dependencies have been added to the REQUIREMENTS variable (example).
  • New dependencies are only imported inside functions that use them (example).
  • New dependencies have been added to requirements_all.txt by running script/gen_requirements_all.py.
  • New files were added to .coveragerc.

If the code does not interact with devices:

  • Tests have been added to verify that the new code works.

Copy link
Copy Markdown
Member

@syssi syssi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add some notice about the feature at the docs.

@n8henrie
Copy link
Copy Markdown
Contributor Author

@pvizeli pvizeli merged commit 1053473 into home-assistant:dev May 16, 2018
@balloob balloob mentioned this pull request May 28, 2018
girlpunk pushed a commit to girlpunk/home-assistant that referenced this pull request Sep 4, 2018
@home-assistant home-assistant locked and limited conversation to collaborators Sep 5, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants