Skip to content

Don't add a url to built-in panels#14456

Merged
balloob merged 5 commits into
devfrom
frontend-polymer-3
May 15, 2018
Merged

Don't add a url to built-in panels#14456
balloob merged 5 commits into
devfrom
frontend-polymer-3

Conversation

@balloob
Copy link
Copy Markdown
Member

@balloob balloob commented May 13, 2018

Description:

This is a change to support the Polymer 3 conversion of the frontend happening at home-assistant/frontend#1154

Example entry for configuration.yaml (if applicable):

frontend:

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass

If the code does not interact with devices:

  • Tests have been added to verify that the new code works.

@pvizeli
Copy link
Copy Markdown
Member

pvizeli commented May 14, 2018

A lot better als the old code. That was a but wired.

@balloob balloob changed the title WIP: Don't add a url to built-in panels Don't add a url to built-in panels May 15, 2018
@balloob balloob merged commit df69680 into dev May 15, 2018
@balloob balloob deleted the frontend-polymer-3 branch May 15, 2018 18:49
@balloob balloob mentioned this pull request May 28, 2018
girlpunk pushed a commit to girlpunk/home-assistant that referenced this pull request Sep 4, 2018
* Don't add a url to built-in panels

* Add url_path back

* Lint

* Frontend bump to 20180515.0

* Fix tests
@home-assistant home-assistant locked and limited conversation to collaborators Sep 5, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants