Add script to run monkeytype typing on test suite #14440
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* The monkeytype script takes an optional argument to specify a test module or directory to run. Otherwise the whole test suite will run. * Add monkeytype sqlite db to gitignore.
|
CC @andrey-git |
balloob
approved these changes
Jun 7, 2018
|
Can you add a page to https://developers.home-assistant.io/ with instructions ? |
eavanvalkenburg
pushed a commit
to eavanvalkenburg/home-assistant
that referenced
this pull request
Jun 28, 2018
* The monkeytype script takes an optional argument to specify a test module or directory to run. Otherwise the whole test suite will run. * Add monkeytype sqlite db to gitignore.
Merged
girlpunk
pushed a commit
to girlpunk/home-assistant
that referenced
this pull request
Sep 4, 2018
* The monkeytype script takes an optional argument to specify a test module or directory to run. Otherwise the whole test suite will run. * Add monkeytype sqlite db to gitignore.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
See this instagram blog post for a description of the workflow involved to use the monkeytype program.
Basic workflow:
script/monkeytype tests/path/to/your_test_module.py.monkeytype stub homeassistant.your_actual_module.monkeytype apply homeassistant.your_actual_module.Note:
Applying a monkeytyped stub to a module that has existing typing annotations might error and not work. This tool is most useful for totally untyped modules.
https://developers.home-assistant.io/docs/en/development_typing.html
Related issue (if applicable):
#14410 (comment)
Checklist: