Add support to ignore a xiaomi aqara gateway#14428
Conversation
|
Why would you want to support disabled gateways? |
|
The auto discovery picks up all available gateways. May be selected ones shouldn't interact with HA. |
|
The title and description of the PR is misleading. |
|
emmm...yes,,my english is so bad...@syssi thanks for your help |
|
Wouldn't it be better to use the configurator for this? |
|
Could you explain this? |
|
The configurator would allow configuration of each identifies gateway directly in the gui. Then it would just be a check box to disable/ignore |
|
Do you mean the hassio add-on? In this case the approach here is the right one. |
| CONF_GATEWAYS = 'gateways' | ||
| CONF_INTERFACE = 'interface' | ||
| CONF_KEY = 'key' | ||
| CONF_DISABLED = 'disabled' |
There was a problem hiding this comment.
Could you rename the setting from "disabled" to "disable"?
|
This PR requires an upcoming release of PyXiaomiGateway. |
|
I've released PyXiaomiGateway 0.9.4. Please update the requirements of homeassistant/components/xiaomi_aqara.py. |
|
I've added some docs: home-assistant/home-assistant.io#5388 |
|
|
Instead calling gen_requirements_all.py you could increment the PyXiaomiGateway version at |
Description:
Introduces a configuration parameter to ignore a Xiaomi Gateway. Per default all available gateways are discovered and handled by Home Assistant.
Checklist:
tox. Your PR cannot be merged unless tests passIf user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
REQUIREMENTSvariable (example).requirements_all.txtby runningscript/gen_requirements_all.py..coveragerc.If the code does not interact with devices: