BMW code cleanup#14424
Merged
syssi merged 3 commits intohome-assistant:devfrom May 15, 2018
gerard33:bmw-cleanup
Merged
Conversation
| elif self._attribute == 'charging_status': | ||
| return 'mdi:battery-charging' | ||
| elif self._attribute == 'charging_level_hv': | ||
| for key, value in ATTR_TO_HA.items(): |
Member
There was a problem hiding this comment.
if self._attribute == 'charging_level_hv':
return icon_for_battery_level(...)
icon, _ = ATTR_TO_HA.get(self._attribute, [None, None])
return icon| return 'h' | ||
| elif self._attribute == 'charging_level_hv': | ||
| return '%' | ||
| for key, value in ATTR_TO_HA.items(): |
| 'CONNECTED') | ||
|
|
||
| def _format_cbs_report(self, report): | ||
| result = dict() |
MartinHjelmare
approved these changes
May 13, 2018
Merged
2 tasks
girlpunk
pushed a commit
to girlpunk/home-assistant
that referenced
this pull request
Sep 4, 2018
* Some cleanup for BMW sensors * Changed dict sort * Updates based on review and Travis
ghost
added
integration: bmw_connected_drive
and removed
platform: binary_sensor.bmw_connected_drive
labels
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:
As suggested by @MartinHjelmare in #14293 some cleanups in the if...elif trails are made.
Checklist:
tox. Your PR cannot be merged unless tests pass