Skip to content

Wait for future mysensors gateway ready#14398

Merged
balloob merged 2 commits intohome-assistant:devfrom
MartinHjelmare:wait-ready-gateway
May 19, 2018
Merged

Wait for future mysensors gateway ready#14398
balloob merged 2 commits intohome-assistant:devfrom
MartinHjelmare:wait-ready-gateway

Conversation

@MartinHjelmare
Copy link
Copy Markdown
Member

@MartinHjelmare MartinHjelmare commented May 11, 2018

Description:

  • Add an asyncio future that is done when the gateway reports the gateway ready message, I_GATEWAY_READY.
  • This will make sure that the gateway is ready before home assistant fires the home assistant start event. Automations can now send messages to the gateway when home assistant is started.
  • Use async timeout to wait max 15 seconds for ready gateway.

Related issue (if applicable):
fixes #13257

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass

Comment thread homeassistant/components/mysensors.py Outdated
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's clean it up from hass.data

Comment thread homeassistant/components/mysensors.py Outdated
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

merge with previous if.

* Add an asyncio future that is done when the gateway reports the
  gateway ready message, I_GATEWAY_READY.
* This will make sure that the gateway is ready before home assistant
  fires the home assistant start event. Automations can now send
  messages to the gateway when home assistant is started.
* Use async timeout to wait max 15 seconds for ready gateway.
@balloob balloob merged commit c8a53c5 into home-assistant:dev May 19, 2018
@balloob balloob added this to the 0.70.0 milestone May 19, 2018
balloob pushed a commit that referenced this pull request May 21, 2018
* Wait for future mysensors gateway ready

* Add an asyncio future that is done when the gateway reports the
  gateway ready message, I_GATEWAY_READY.
* This will make sure that the gateway is ready before home assistant
  fires the home assistant start event. Automations can now send
  messages to the gateway when home assistant is started.
* Use async timeout to wait max 15 seconds for ready gateway.

* Address comments
@balloob balloob mentioned this pull request May 28, 2018
girlpunk pushed a commit to girlpunk/home-assistant that referenced this pull request Sep 4, 2018
* Wait for future mysensors gateway ready

* Add an asyncio future that is done when the gateway reports the
  gateway ready message, I_GATEWAY_READY.
* This will make sure that the gateway is ready before home assistant
  fires the home assistant start event. Automations can now send
  messages to the gateway when home assistant is started.
* Use async timeout to wait max 15 seconds for ready gateway.

* Address comments
@home-assistant home-assistant locked and limited conversation to collaborators Sep 5, 2018
@MartinHjelmare MartinHjelmare deleted the wait-ready-gateway branch October 11, 2018 09:27
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Notify Mysensors no longer working

3 participants