Skip to content

Rewritten HomeKit tests#14377

Merged
cdce8p merged 1 commit intohome-assistant:devfrom
cdce8p:homekit-tests
May 10, 2018
Merged

Rewritten HomeKit tests#14377
cdce8p merged 1 commit intohome-assistant:devfrom
cdce8p:homekit-tests

Conversation

@cdce8p
Copy link
Copy Markdown
Member

@cdce8p cdce8p commented May 10, 2018

Description:

I have rewritten almost all HomeKit tests to use pytest fixtures instead of unittest.
coverage remains the same, 100%.

Changes

  • Use async
  • Change to assert
  • Use pytest fixtures and parametrize

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass

* Use pytest fixtures and parametrize
* Use async
@cdce8p
Copy link
Copy Markdown
Member Author

cdce8p commented May 10, 2018

Merging this now, so other PRs can move forward. #14159 #14351

CC: @schmittx

@cdce8p cdce8p merged commit 8fcf085 into home-assistant:dev May 10, 2018
@cdce8p cdce8p deleted the homekit-tests branch May 10, 2018 23:22
@cdce8p cdce8p mentioned this pull request May 12, 2018
2 tasks
@balloob balloob mentioned this pull request May 28, 2018
girlpunk pushed a commit to girlpunk/home-assistant that referenced this pull request Sep 4, 2018
* Use pytest fixtures and parametrize
* Use async
@home-assistant home-assistant locked and limited conversation to collaborators Sep 5, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants