Skip to content

Partial packets breaking hbmqtt#14329

Merged
balloob merged 1 commit intohome-assistant:devfrom
graffic:dev
May 7, 2018
Merged

Partial packets breaking hbmqtt#14329
balloob merged 1 commit intohome-assistant:devfrom
graffic:dev

Conversation

@graffic
Copy link
Copy Markdown
Contributor

@graffic graffic commented May 7, 2018

This issue was fixed in hbmqtt/issues#95 that was released in hbmqtt 0.9.2

Description:

Related issue (if applicable): brings fix for njouanin/hbmqtt#95

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass

If the code communicates with devices, web services, or third-party tools:

  • Updateddependencies have been added to the REQUIREMENTS variable
  • Updated dependencies are only imported inside functions that use them
  • Updated dependencies have been added to requirements_all.txt by running script/gen_requirements_all.py.

If the code does not interact with devices:

  • Tests have been added to verify that the new code works. <--- No new tests added

This issue was fixed in hbmqtt/issues#95 that was released in hbmqtt 0.9.2
@graffic graffic requested a review from a team as a code owner May 7, 2018 11:15
@homeassistant
Copy link
Copy Markdown
Contributor

Hi @graffic,

It seems you haven't yet signed a CLA. Please do so here.

Once you do that we will be able to review and accept this pull request.

Thanks!

@graffic
Copy link
Copy Markdown
Contributor Author

graffic commented May 7, 2018

This issue manifests with micropython's mqtt library. It sends the MQTT packet in different TCP packets.

@balloob balloob added this to the 0.69 milestone May 7, 2018
@balloob balloob merged commit a2b8ad5 into home-assistant:dev May 7, 2018
@balloob
Copy link
Copy Markdown
Member

balloob commented May 7, 2018

Awesome, thanks!

balloob pushed a commit that referenced this pull request May 7, 2018
This issue was fixed in hbmqtt/issues#95 that was released in hbmqtt 0.9.2
@fabaff fabaff changed the title fix(hbmqtt): partial packets breaking hbmqtt Partial packets breaking hbmqtt May 8, 2018
@balloob balloob mentioned this pull request May 11, 2018
girlpunk pushed a commit to girlpunk/home-assistant that referenced this pull request Sep 4, 2018
This issue was fixed in hbmqtt/issues#95 that was released in hbmqtt 0.9.2
@home-assistant home-assistant locked and limited conversation to collaborators Sep 5, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants