Add sensors and services to RainMachine by bachya · Pull Request #14326 · home-assistant/core

bachya · 2018-05-07T03:21:26Z

Description:

Adds several (binary) sensors to the RainMachine component:

Binary Sensor: Extra Water on Hot Days
Binary Sensor: Freeze Protection
Binary Sensor: Freeze Restrictions
Binary Sensor: Hourly Restrictions
Binary Sensor: Month Restrictions
Binary Sensor: Rain Delay Restrictions
Binary Sensor: Rain Sensor Restrictions
Binary Sensor: Weekday Restrictions
Sensor: Freeze Protect Temperature

Additionally, this PR adds several services:

start_program
start_zone
stop_all
stop_program
stop_zone

Related issue (if applicable): N/A

Pull request in home-assistant.github.io with documentation (if applicable): home-assistant/home-assistant.io#5322

Example entry for `configuration.yaml` (if applicable):

rainmachine:
  ip_address: 192.168.1.100
  password: abc123

Checklist:

The code change is tested and works locally.
Local tests pass with tox. Your PR cannot be merged unless tests pass

If user exposed functionality or configuration variables are added/changed:

Documentation added/updated in home-assistant.github.io

If the code communicates with devices, web services, or third-party tools:
~~- [ ] New dependencies have been added to the REQUIREMENTS variable (example).~~
~~- [ ] New dependencies are only imported inside functions that use them (example).~~
~~- [ ] New dependencies have been added to requirements_all.txt by running script/gen_requirements_all.py.~~
~~- [ ] New files were added to .coveragerc.~~

bachya · 2018-05-16T17:57:17Z

FYI: been running this in my local HASS for a week or so and everything seems to work fine.

balloob · 2018-05-18T01:17:33Z

No need for .keys()

balloob · 2018-05-18T01:19:34Z

Please use git mv <X> <Y> to keep history attached to a file

Not sure what you mean here – I performed git mv homeassistant/components/rainmachine.py homeassistant/components/rainmachine/__init__.py, but the result appears to be the same as before.

balloob · 2018-05-18T01:19:43Z

No device class ?

These are all device configurations, not representations of conditions. Example: TYPE_FREEZE means "Is the device currently restricted from watering because it's too cold outside?" That doesn't seem to fit the spirit of the cold device class. The same is true for the other sensors.

That said, let me know if you'd rather they be coerced into that format and I'll get it done.

balloob · 2018-05-18T01:20:01Z

Don't catch this, instead a voluptuous schema should make sure we never get bad keys.

balloob · 2018-05-18T01:20:53Z

This seems like the RainMachineEntity is overcomplicated. The logic is hard to follow.

balloob · 2018-05-18T01:21:53Z

You need to annotate this as callback or else it will run synchronous

balloob · 2018-05-18T01:23:08Z

Why are the keys called ATTR? Shouldn't it be TYPE or something ?

balloob · 2018-05-18T01:25:24Z

What are these errors? Why isn't Rainmachine raising their own error type?

balloob · 2018-05-18T01:25:49Z

Please remove some of the debugs.

balloob · 2018-05-18T01:28:01Z

Do not log config

balloob · 2018-05-18T01:29:05Z

make a callback.

MartinHjelmare

Ok, merging. 👍

homeassistant added cla-signed integration: rainmachine new-platform platform: switch.rainmachine remove-platform labels May 7, 2018

bachya changed the title ~~Adds sensors and services to RainMachine~~ WIP: Adds sensors and services to RainMachine May 7, 2018

homeassistant added the cla-signed label May 7, 2018

bachya mentioned this pull request May 7, 2018

Adds documentation for latest RainMachine PR home-assistant/home-assistant.io#5322

Merged

2 tasks

bachya force-pushed the rainmachine-3 branch from 55cf16b to fe0e5b5 Compare May 7, 2018 16:23

homeassistant added the cla-signed label May 7, 2018

bachya force-pushed the rainmachine-3 branch from 5ecfa7e to 15ce0d3 Compare May 8, 2018 23:09

homeassistant added the cla-signed label May 8, 2018

bachya changed the title ~~WIP: Adds sensors and services to RainMachine~~ Adds sensors and services to RainMachine May 9, 2018

bachya force-pushed the rainmachine-3 branch from 0d92c0e to 515c635 Compare May 9, 2018 18:08

homeassistant added the cla-signed label May 9, 2018

balloob reviewed May 18, 2018

View reviewed changes

Comment thread homeassistant/components/binary_sensor/rainmachine.py Outdated

Copy link
Copy Markdown

Member

balloob May 18, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No need for .keys()

balloob reviewed May 18, 2018

View reviewed changes

Comment thread homeassistant/components/rainmachine/__init__.py Outdated

Copy link
Copy Markdown

Member

balloob May 18, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please remove some of the debugs.

balloob reviewed May 18, 2018

View reviewed changes

Comment thread homeassistant/components/sensor/rainmachine.py Outdated

Copy link
Copy Markdown

Member

balloob May 18, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do not log config

balloob reviewed May 18, 2018

View reviewed changes

Comment thread homeassistant/components/sensor/rainmachine.py Outdated

Copy link
Copy Markdown

Member

balloob May 18, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

make a callback.

bachya force-pushed the rainmachine-3 branch from f770223 to 3419b36 Compare May 18, 2018 14:37

bachya added 17 commits May 29, 2018 10:50

Moving to async methods

57891cb

Fixed coverage test

9d1edb3

Lint

c0f446d

Removed unnecessary hass reference

bfa3ddb

Lint

856959a

Lint

6bdc2da

Round 1 of Owner-requested changes

4cb581c

Round 2 of Owner-requested changes

63cc18c

Round 3 of Owner-requested changes

4b16dba

Round 4 (final for now) of Owner-requested changes

6e65971

Hound

5293789

Updated package requirements

3832bb1

Lint

2f40713

Collaborator-requested changes

014f657

Collaborator-requested changes

a4039bb

More small tweaks

45ddf36

One more small tweak

0cb1b9a

bachya force-pushed the rainmachine-3 branch from 594bec5 to 0cb1b9a Compare May 29, 2018 16:50

homeassistant added the cla-signed label May 29, 2018

Bumping Travis and Coveralls

e18fc64

MartinHjelmare approved these changes May 29, 2018

View reviewed changes

MartinHjelmare changed the title ~~Adds sensors and services to RainMachine~~ Add sensors and services to RainMachine May 29, 2018

MartinHjelmare merged commit 084b328 into home-assistant:dev May 29, 2018

bachya deleted the rainmachine-3 branch May 29, 2018 20:09

balloob mentioned this pull request Jun 8, 2018

0.71.0 #14876

Merged

home-assistant locked and limited conversation to collaborators Sep 5, 2018

ghost removed platform: binary_sensor.rainmachine labels Mar 21, 2019

Uh oh!

Conversation

bachya commented May 7, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description:

Example entry for configuration.yaml (if applicable):

Checklist:

Uh oh!

bachya commented May 16, 2018

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

bachya May 18, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

MartinHjelmare left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

bachya commented May 7, 2018 •

edited

Loading

Example entry for `configuration.yaml` (if applicable):

bachya May 18, 2018 •

edited

Loading