Merged
Conversation
balloob
force-pushed
the
fix-custom-component-name
branch
from
cdba1c9 to
c58ecf4
Compare
pvizeli
approved these changes
May 6, 2018
Member
Author
|
This doesn't fix it :( Loggers initialize themselves when the module is executed, updating it afterwards is too late. |
balloob
added a commit
that referenced
this pull request
May 7, 2018
* Fix module names for custom components * Also set __package__ correctly * bla * Remove print
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:
After #14211, the
__name__attribute on custom components no longer had thecustom_componentprefix. This fixes it.Related issue (if applicable): fixes #14304
Checklist:
tox. Your PR cannot be merged unless tests passIf the code does not interact with devices: