Gogogate2 0.1.1#14294
Merged
balloob merged 9 commits intohome-assistant:devfrom May 8, 2018
Merged
Conversation
Uses latest version of library which ensures commands to device are idempotent
homeassistant
added
cla-signed
platform: cover.gogogate2
small-pr
houndci-bot
reviewed
May 5, 2018
| def state_attributes(self): | ||
| """Return the state attributes.""" | ||
| data = super().state_attributes | ||
| data[ATTR_TEMPERATURE] = self._temperature |
| def supported_features(self): | ||
| """Flag supported features.""" | ||
| return SUPPORT_OPEN | SUPPORT_CLOSE | ||
|
|
Member
|
Please fix the build error! |
balloob
previously requested changes
May 5, 2018
| def state_attributes(self): | ||
| """Return the state attributes.""" | ||
| data = super().state_attributes | ||
| data[ATTR_TEMPERATURE] = self._temperature |
Member
There was a problem hiding this comment.
This should not be added as an attribute but instead be made into it's own sensor. This means that you will need to greate a gogogate2 component to handle the connection and then setup the cover and sensor platforms.
Contributor
Author
There was a problem hiding this comment.
Fair enough. For now, I'll update the PR to get the bug fix in and look at adding the component/sensors later.
For additional data points such as battery_level of the garage tilt sensor - should that be added as an attribute of the cover platform or should it be its own sensor too?
Removed temperature attribute until it can be re-implemented as a separate sensor.
houndci-bot
reviewed
May 8, 2018
| ip_address = config.get(CONF_IP_ADDRESS) | ||
| name = config.get(CONF_NAME) | ||
| password = config.get(CONF_PASSWORD) | ||
| username = config.get(CONF_USERNAME) |
There was a problem hiding this comment.
unexpected spaces around keyword / parameter equals
| password = config.get(CONF_PASSWORD) | ||
| ip_address = config.get(CONF_IP_ADDRESS) | ||
| name = config.get(CONF_NAME) | ||
| password = config.get(CONF_PASSWORD) |
There was a problem hiding this comment.
unexpected spaces around keyword / parameter equals
Merged
girlpunk
pushed a commit
to girlpunk/home-assistant
that referenced
this pull request
Sep 4, 2018
* Gogogate2 - bump version Uses latest version of library which ensures commands to device are idempotent * Update requirements_all * Expose sensor temperature * update version * import attribute * Set temperature * Remove temperature attribute Removed temperature attribute until it can be re-implemented as a separate sensor. * Update ordering * Fix copy-&-paste issue
ghost
added
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:
Update to use latest version of gogogate2 component. Expose device temperature as attribute
Checklist:
tox. Your PR cannot be merged unless tests passIf user exposed functionality or configuration variables are added/changed: