Skip to content

fix check config not working after #14211#14259

Merged
pvizeli merged 1 commit intohome-assistant:devfrom
fanthos:config
May 4, 2018
Merged

fix check config not working after #14211#14259
pvizeli merged 1 commit intohome-assistant:devfrom
fanthos:config

Conversation

@fanthos
Copy link
Copy Markdown
Contributor

@fanthos fanthos commented May 3, 2018

Description:

When clicking Check configuration or Restart Service in Web UI, I got the following error log:
Seems that config.py didn't change to fit the new reload function.

2018-05-03 12:07:35 ERROR (MainThread) [aiohttp.server] Error handling request
Traceback (most recent call last):
  File "/mnt/c/Workspaces/github/home-assistant/lvenv/lib/python3.6/site-packages/aiohttp/web_protocol.py", line 381, in start
    resp = await self._request_handler(request)
  File "/mnt/c/Workspaces/github/home-assistant/lvenv/lib/python3.6/site-packages/aiohttp/web_app.py", line 322, in _handle
    resp = await handler(request)
  File "/mnt/c/Workspaces/github/home-assistant/lvenv/lib/python3.6/site-packages/aiohttp/web_middlewares.py", line 88, in impl
    return await handler(request)
  File "/mnt/c/Workspaces/github/home-assistant/homeassistant/components/http/static.py", line 68, in staticresource_middleware
    return await handler(request)
  File "/mnt/c/Workspaces/github/home-assistant/homeassistant/components/http/real_ip.py", line 27, in real_ip_middleware
    return await handler(request)
  File "/mnt/c/Workspaces/github/home-assistant/homeassistant/components/http/ban.py", line 68, in ban_middleware
    return await handler(request)
  File "/mnt/c/Workspaces/github/home-assistant/homeassistant/components/http/auth.py", line 28, in auth_middleware
    return await handler(request)
  File "/mnt/c/Workspaces/github/home-assistant/homeassistant/components/http/view.py", line 104, in handle
    result = await result
  File "/mnt/c/Workspaces/github/home-assistant/homeassistant/components/config/core.py", line 24, in post
    errors = yield from async_check_ha_config_file(request.app['hass'])
  File "/mnt/c/Workspaces/github/home-assistant/homeassistant/config.py", line 690, in async_check_ha_config_file
    check_ha_config_file, hass.config.config_dir)
  File "/usr/lib/python3.6/concurrent/futures/thread.py", line 56, in run
    result = self.fn(*self.args, **self.kwargs)
  File "/mnt/c/Workspaces/github/home-assistant/homeassistant/scripts/check_config.py", line 288, in check_ha_config_file
    config_dir = hass.config.config_dir
AttributeError: 'str' object has no attribute 'config'

@fanthos fanthos requested a review from a team as a code owner May 3, 2018 04:29
@homeassistant homeassistant added cla-signed core small-pr PRs with less than 30 lines. labels May 3, 2018
@dgomes dgomes added the bug label May 3, 2018
@pvizeli pvizeli added this to the 0.68.2 milestone May 4, 2018
@pvizeli pvizeli merged commit c80b752 into home-assistant:dev May 4, 2018
@fanthos
Copy link
Copy Markdown
Contributor Author

fanthos commented May 4, 2018

@pvizeli this PR should merge wuth #14211 or it will break current code. Seems that the original PR not coming in 0.68.2.

@pvizeli pvizeli removed this from the 0.68.2 milestone May 4, 2018
@balloob
Copy link
Copy Markdown
Member

balloob commented May 4, 2018

Thanks

@balloob balloob mentioned this pull request May 11, 2018
@home-assistant home-assistant locked and limited conversation to collaborators Sep 5, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

bug cla-signed core small-pr PRs with less than 30 lines.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants