Fix Hue color state for missing xy#14230
Merged
balloob merged 1 commit intohome-assistant:devfrom May 2, 2018
Merged
Conversation
2 tasks
Member
|
haha I was just looking at the other PR and I was, wait a second, my comment about the issue got removed and we no longer guard against it . |
Contributor
Author
|
To be fair, your comment was about the I really hope it's back to working now, debugging without having the hardware is difficult 😅 |
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:
I made a mistake with my revert in #14154, I missed that the original code used
get()to handle non-existent keys. Sorry 😢.Related issue (if applicable): reported in #14113 (comment)
Checklist:
tox.If the code does not interact with devices: