Skip to content

Fix Hue color state for missing xy#14230

Merged
balloob merged 1 commit intohome-assistant:devfrom
amelchio:hue-test-xy
May 2, 2018
Merged

Fix Hue color state for missing xy#14230
balloob merged 1 commit intohome-assistant:devfrom
amelchio:hue-test-xy

Conversation

@amelchio
Copy link
Copy Markdown
Contributor

@amelchio amelchio commented May 1, 2018

Description:

I made a mistake with my revert in #14154, I missed that the original code used get() to handle non-existent keys. Sorry 😢.

Related issue (if applicable): reported in #14113 (comment)

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox.

If the code does not interact with devices:

  • Tests have been added to verify that the new code works.

@amelchio amelchio added this to the 0.68.2 milestone May 1, 2018
@balloob
Copy link
Copy Markdown
Member

balloob commented May 2, 2018

haha I was just looking at the other PR and I was, wait a second, my comment about the issue got removed and we no longer guard against it .

@balloob balloob merged commit bf056b6 into home-assistant:dev May 2, 2018
@amelchio
Copy link
Copy Markdown
Contributor Author

amelchio commented May 2, 2018

To be fair, your comment was about the hue and sat keys not always being present and that is indeed no longer an issue. I just missed that the same thing applies to xy :-/

I really hope it's back to working now, debugging without having the hardware is difficult 😅

@balloob balloob removed this from the 0.68.2 milestone May 9, 2018
@balloob balloob mentioned this pull request May 11, 2018
@home-assistant home-assistant locked and limited conversation to collaborators Sep 5, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

cla-signed integration: hue small-pr PRs with less than 30 lines.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants