Converts RainMachine to hub model (part 2)#14225
Merged
balloob merged 6 commits intohome-assistant:devfrom May 1, 2018
Merged
Conversation
2 tasks
balloob
approved these changes
May 1, 2018
arsaboo
pushed a commit
to home-assistant/home-assistant.io
that referenced
this pull request
May 3, 2018
* Adds docs for RainMachine component/hub * Removing references to remote API * Collaborator-requested changes * Adding new info (per home-assistant/core#14225) * Collaborator-requested changes * Collaborator-requested changes * Revert "Collaborator-requested changes" This reverts commit 34f75ff. * I think I got it this time... * Collaborator-requested changes * Collaborator-requested changes * Small tweak
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:
#14085 was the first cut at moving RainMachine to a hub/component model (for future functionality). After discussion with @balloob, I want to tweak things so that the
rainmachinecomponent forwards discovery of entities to the platforms (which will make configuration easier, as shown below).BREAKING CHANGE: #14085 (already merged) broke the existing format; this will do so again. If we can merge this before #14085 is released, we will limit to one breaking change (ideal) and can use the message described in that PR.
CC: @MartinHjelmare
Related issue (if applicable): N/A
Pull request in home-assistant.github.io with documentation (if applicable): home-assistant/home-assistant.io#5251 (although this related to #14085 originally, since it hasn't been merged, going to hustle and use it for this PR, as well)
Example entry for
configuration.yaml(if applicable):Checklist:
tox. Your PR cannot be merged unless tests passIf user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
- [ ] New dependencies have been added to theREQUIREMENTSvariable (example).- [ ] New dependencies are only imported inside functions that use them (example).- [ ] New dependencies have been added torequirements_all.txtby runningscript/gen_requirements_all.py.- [ ] New files were added to.coveragerc.