Skip to content

Fix TypeError on round(self.humidity) (fixes #13116) #14174

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
balloob merged 2 commits into from
Apr 30, 2018
Merged

Fix TypeError on round(self.humidity) (fixes #13116) #14174

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
97165a3
Fix TypeError on round(self.humidity)
mvn23 Apr 29, 2018
dadbd0d
Rewrite to avoid false negative evaluation
mvn23 Apr 30, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion homeassistant/components/weather/__init__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -110,7 +110,8 @@ def state_attributes(self):
ATTR_WEATHER_TEMPERATURE: show_temp(
self.hass, self.temperature, self.temperature_unit,
self.precision),
ATTR_WEATHER_HUMIDITY: round(self.humidity)
ATTR_WEATHER_HUMIDITY: (round(self.humidity) if self.humidity

@OttoWinter OttoWinter Apr 30, 2018

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The if self.humidity check will not work with falsy values like 0.0.

Write something like if self.humidity is not None or, even better, make it an additional check like the other attributes:

data = {
            ATTR_WEATHER_TEMPERATURE: show_temp(
                self.hass, self.temperature, self.temperature_unit,
                self.precision),
        }

        humidity = self.humidity
        if humidity is not None:
            data[ATTR_WEATHER_HUMIDITY] = humidity

@mvn23 mvn23 Apr 30, 2018

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You are absolutely right, hadn't thought about that.
Even though humidity is probably never going to be 0, we should definitely take it into account.
Fixed in the commit below.

else None)
}

ozone = self.ozone
Expand Down