Skip to content

Added update_interval to maxcube #14143

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
syssi merged 3 commits into from
Apr 29, 2018
Merged

Added update_interval to maxcube #14143

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
3613881
Added update_interval to maxcube
dingusdk Apr 28, 2018
dff6f14
Change update_interval to scan_interval
dingusdk Apr 28, 2018
cb8d9f3
Change scan_interval to time_period
dingusdk Apr 28, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 8 additions & 5 deletions homeassistant/components/maxcube.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@

import homeassistant.helpers.config_validation as cv
from homeassistant.helpers.discovery import load_platform
from homeassistant.const import CONF_HOST, CONF_PORT
from homeassistant.const import CONF_HOST, CONF_PORT, CONF_SCAN_INTERVAL

REQUIREMENTS = ['maxcube-api==0.1.0']

Expand All @@ -32,6 +32,7 @@
CONFIG_GATEWAY = vol.Schema({
vol.Required(CONF_HOST): cv.string,
vol.Optional(CONF_PORT, default=DEFAULT_PORT): cv.port,
vol.Optional(CONF_SCAN_INTERVAL, default=300): cv.time_period,
})

CONFIG_SCHEMA = vol.Schema({
Expand All @@ -54,10 +55,11 @@ def setup(hass, config):
for gateway in gateways:
host = gateway[CONF_HOST]
port = gateway[CONF_PORT]
scan_interval = gateway[CONF_SCAN_INTERVAL].total_seconds()

try:
cube = MaxCube(MaxCubeConnection(host, port))
hass.data[DATA_KEY][host] = MaxCubeHandle(cube)
hass.data[DATA_KEY][host] = MaxCubeHandle(cube, scan_interval)
except timeout as ex:
_LOGGER.error("Unable to connect to Max!Cube gateway: %s", str(ex))
hass.components.persistent_notification.create(
Expand All @@ -80,18 +82,19 @@ def setup(hass, config):
class MaxCubeHandle(object):
"""Keep the cube instance in one place and centralize the update."""

def __init__(self, cube):
def __init__(self, cube, scan_interval):
"""Initialize the Cube Handle."""
self.cube = cube
self.scan_interval = scan_interval
self.mutex = Lock()
self._updatets = time.time()

def update(self):
"""Pull the latest data from the MAX! Cube."""
# Acquire mutex to prevent simultaneous update from multiple threads
with self.mutex:
# Only update every 60s
if (time.time() - self._updatets) >= 60:
# Only update every update_interval
if (time.time() - self._updatets) >= self.scan_interval:
_LOGGER.debug("Updating")

try:
Expand Down