Convert more files to async/await syntax#14142
Merged
balloob merged 2 commits intohome-assistant:devfrom Apr 28, 2018
Merged
Conversation
OttoWinter
commented
Apr 28, 2018
| @asyncio.coroutine | ||
| @patch('homeassistant.bootstrap.async_enable_logging', Mock()) | ||
| @patch('homeassistant.bootstrap.async_register_signal_handling', Mock()) | ||
| @asyncio.coroutine |
Member
Author
There was a problem hiding this comment.
This test was failing because of the order of these decorators. I'm not sure why this is though, as to me it makes more sense if it worked if the @asyncio.coroutine decorator is placed before the other decorators.
Anyway, this test passes now and I verified that the code block in here is actually executed.
OttoWinter
changed the title
balloob
approved these changes
Apr 28, 2018
Member
|
ok to merge when you fix the linting issues. |
Using lazytox :P
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:
This PR converts a few files to use the new and awesome
async/awaitsyntax in components I personally use.As some of these components do not have good test coverage, I've been testing these changes for the last few days and I have not seen issues come up.
If it's a lot to review, I can also split it up into individual PRs.
Related issue (if applicable): #12614
Checklist:
tox. Your PR cannot be merged unless tests pass