Add HomeKit firmware revision characteristic#14112
Closed
schmittx wants to merge 2 commits intohome-assistant:devfrom
Closed
Add HomeKit firmware revision characteristic#14112schmittx wants to merge 2 commits intohome-assistant:devfrom
schmittx wants to merge 2 commits intohome-assistant:devfrom
Conversation
cdce8p
requested changes
Apr 27, 2018
| service.get_characteristic(CHAR_MANUFACTURER).set_value(manufacturer) | ||
| service.get_characteristic(CHAR_SERIAL_NUMBER).set_value(serial_number) | ||
| (service.get_characteristic(CHAR_FIRMWARE_REVISION) | ||
| .set_value(firmware_revision)) |
Member
There was a problem hiding this comment.
Use the following instead:
service.get_characteristic(CHAR_FIRMWARE_REVISION) \
.set_value(firmware_revision)
Contributor
Author
|
I agree, not exactly necessary but I though it worked nicely to use the Home Assistant version. I've added this to #14114. |
8 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:
Adds characteristic to accessory information service for firmware revision. By default, firmware revision is set to current Home Assistant version.
Related issue (if applicable): N/A
Pull request in home-assistant.github.io with documentation (if applicable): N/A
Example entry for
configuration.yaml(if applicable):N/AChecklist:
tox. Your PR cannot be merged unless tests passIf user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
REQUIREMENTSvariable (example).requirements_all.txtby runningscript/gen_requirements_all.py..coveragerc.If the code does not interact with devices: