Fix color setting of tplink lights#14108
Merged
balloob merged 1 commit intohome-assistant:devfrom Apr 28, 2018
Merged
Conversation
Member
|
I'm removing this from the milestone as the release is going out today and no one with hardware seems to have tested this. |
|
I was able to load this tplink.py and can confirm that it fixed my color issue.
|
Contributor
Author
|
@balloob That's fine, I agree with not adding untested code to the final release. As it is tested now and a fairly serious bug for those affected, are you okay with adding it to 0.68.1 even if the regression happened a few releases ago? @Arkadyf Thanks for testing. That is a fine way to do it with minimal impact to the running system. BTW, I found an existing issue for this bug: #13924 |
Member
|
Yes, fine with 0.68.1 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:
This hopefully fixes TPLink lights after the hue/sat update. I noticed a few other issues as well.
I do not have hardware to test this so please review closely.
ATTR_KELVINas it should not reach platforms.CC @Arkadyf, @armills
Related issue (if applicable): fixes #13924, also reported in #11288 (comment)
Checklist:
tox.