Fix BOM weather '-' value by nickw444 · Pull Request #14042 · home-assistant/core

nickw444 · 2018-04-22T07:00:17Z

Description:

BOM weather only provide forecast data every few updates, so the state usually looks like the following:

With occasional data along the way

This PR uses the historical data to show the last, non - value for the weather sensor to fix this issue for weather only.

Example entry for `configuration.yaml` (if applicable):

weather:
  - platform: bom
    station: IDN60901.94767
sensor:
  - platform: bom
    station: IDN60901.94767
    name: Sydney
    monitored_conditions:
      - apparent_t
      - cloud
      - cloud_base_m
      - cloud_oktas
      - cloud_type_id
      - cloud_type
      - delta_t
      - gust_kmh
      - gust_kt
      - air_temp
      - dewpt
      - press
      - press_qnh
      - press_msl
      - press_tend
      - rain_trace
      - rel_hum
      - sea_state
      - swell_dir_worded
      - swell_height
      - swell_period
      - vis_km
      - weather
      - wind_dir
      - wind_spd_kmh
      - wind_spd_kt

Checklist:

The code change is tested and works locally.
Local tests pass with tox. Your PR cannot be merged unless tests pass

If the code communicates with devices, web services, or third-party tools:

~~New dependencies have been added to the REQUIREMENTS variable (example).~~
~~New dependencies are only imported inside functions that use them (example).~~
~~New dependencies have been added to requirements_all.txt by running script/gen_requirements_all.py.~~
~~New files were added to .coveragerc.~~

If the code does not interact with devices:

Tests have been added to verify that the new code works.

houndci-bot · 2018-04-22T07:00:26Z

+
+        self.assertEqual('Fine', self.hass.states.get(f'sensor.bom_fake_weather').state)
+        self.assertEqual('1021.7', self.hass.states.get(f'sensor.bom_fake_pressure_mb').state)
+        self.assertEqual('25.0', self.hass.states.get(f'sensor.bom_fake_feels_like_c').state)


line too long (93 > 79 characters)

houndci-bot · 2018-04-22T07:00:26Z

+            self.hass, sensor.DOMAIN, {'sensor': VALID_CONFIG}))
+
+        self.assertEqual('Fine', self.hass.states.get(f'sensor.bom_fake_weather').state)
+        self.assertEqual('1021.7', self.hass.states.get(f'sensor.bom_fake_pressure_mb').state)


line too long (94 > 79 characters)

houndci-bot · 2018-04-22T07:00:26Z

+        self.assertTrue(setup_component(
+            self.hass, sensor.DOMAIN, {'sensor': VALID_CONFIG}))
+
+        self.assertEqual('Fine', self.hass.states.get(f'sensor.bom_fake_weather').state)


line too long (88 > 79 characters)

houndci-bot · 2018-04-22T07:00:26Z

+            self.assertTrue(setup_component(self.hass, sensor.DOMAIN, {
+                'sensor': VALID_CONFIG}))
+
+        fake_entities = ['bom_fake_feels_like_c', 'bom_fake_pressure_mb', 'bom_fake_weather']


line too long (93 > 79 characters)

houndci-bot · 2018-04-22T07:00:26Z

+from homeassistant.setup import setup_component
+from homeassistant.components import sensor
+
+from tests.common import (get_test_home_assistant, assert_setup_component, load_fixture)


line too long (88 > 79 characters)

houndci-bot · 2018-04-22T07:00:26Z

+        item_filter = lambda x: True
+        if condition in ['weather', 'sea_state']:
+            # Take the first non '-' reading.
+            item_filter = lambda x: x is not None and x != '-'


do not assign a lambda expression, use a def

houndci-bot · 2018-04-22T07:00:26Z

+        Iterators are used in this method to avoid iterating needlessly
+        iterating through the entire BOM provided dataset
+        """
+        item_filter = lambda x: True


do not assign a lambda expression, use a def

OttoWinter · 2018-04-22T10:09:55Z

+    @property
+    def latest_data(self):
+        """Return the latest data object"""
+        if self._data and len(self._data) > 0:


The second condition len(self._data) is unnecessary here, because if self._data already checks for a "truthy" value. If self._data is None or is an empty list, then if self._data will already evaluate to False.

OttoWinter · 2018-04-22T10:17:44Z

-        if self.rest.data and self._condition in self.rest.data:
-            return self.rest.data[self._condition]
+        reading = self.rest.get_reading(self._condition)
+        if reading is not None and reading != '-':


I think the latter condition here reading != '-' is unnecessary because get_reading already checks for '-' values for the weather condition. I would suggest removing it here to avoid having the same logic in multiple places which could eventually lead to bugs.

You can just return reading here without the None check. When entity.state returns None it is automatically converted to an unknown state. In fact, it's even recommended to indicate an unknown state with a None value and returning STATE_UNKNOWN is not recommended.

get_reading already checks for '-' values for the weather condition.

Yep, for the weather condition, but it also exists for other conditions like cloud_type , which sometimes will sometimes be - because there are no clouds (so using a historical value isn't right) (and Unknown should be the value shown in the frontend)

See: http://www.bom.gov.au/fwo/IDN60901/IDN60901.94767.json

Do you think this case should also be handled in BOMCurrentData.get_reading (i.e. BOMCurrentData will do the conversion of '-' to None?

As an aside, I will update the STATE_UNKNOWN to return None instead.

Yes then I would move that logic into get_reading.

houndci-bot · 2018-04-22T11:23:06Z

+            return True
+
+        condition_readings = (entry[condition] for entry in self._data)
+        latest_reading = next((x for x in condition_readings if item_filter(x)), None)


line too long (86 > 79 characters)

balloob · 2018-04-22T20:45:00Z

Shouldn't we just delay our scan interval so that there is always a reading?

nickw444 · 2018-04-22T22:41:04Z

Shouldn't we just delay our scan interval so that there is always a reading?

I don't think that's an ideal solution. The time frame between each "real" reading is about 3 hours, so 3 hour old weather data isn't very useful for the other conditions.

Also, whilst it appears BOM give data every 3 hours between 3:14 and 3:44 (and subsequently every 3 hours after that, there doesn't seem to be any "contract" that documents this, and thus if BOM were to change their frequency, or perhaps started issuing weather forecasts more frequently or at a different time offset, it would break this implementation, so I don't think it's a viable approach.

balloob · 2018-04-23T15:15:08Z

But we can be a bit smarter though? The moment we get a proper reading we will not do another update for 3 hours?

nickw444 · 2018-04-23T22:59:25Z

The moment we get a proper reading we will not do another update for 3 hours?

Yes we could do that, but:

1. What if BOM changes the update interval?

Yes, it's unlikely, so probably not a huge issue, but say they take 3 hours and 15 minutes to provide new data, what happens at the refresh we do at the 3 hour mark when there still is no valid data? Do we wait for another 3 hours and expect valid data to come in? What if it never comes in? Do we revert to checking at a higher frequency? It seems like there would be a few edge cases around timing that would need to be handled (and IMO quite complex to deal with)

2. What about other conditions like current temperature?

If we want to keep updating these at a higher frequency, (which we would, since BOM provide higher frequency measurements for these properties), then we need to consider the weather condition as a special snowflake in regards to refresh time. Something that doesn't sound too easy to keep maintainable.

nickw444 · 2018-04-30T01:45:26Z

Hey @balloob @OttoWinter any update on this?

OttoWinter

As one API call updates several conditions and some condition have a higher update frequency, I agree we shouldn't set the global update interval to 3 hours.

OttoWinter · 2018-05-01T13:47:40Z

@@ -202,13 +234,13 @@ def update(self):



Not really part of this PR, but in the if statement above we check if the last update was within 35 minutes.

Can't we just set MIN_TIME_BETWEEN_UPDATES to 35 minutes? The Throttle should take care of it. I'm a bit confused.

Sounds good to me I'll raise another PR

OttoWinter · 2018-05-01T13:51:19Z

+        latest_reading = next(
+            (x for x in condition_readings if should_include_value(x)), None)
+        if latest_reading == '-':
+            # Show a unknown state if a '-' value is encountered.


It's weird that - values in the state are handled differently for weather conditions than for other conditions. Shouldn't we just always take the first non - value?

Like this:

condition_readings = (entry[condition] for entry in self._data) return next((x for x in condition_readings if x != '-'), None)

I think we can. I was under the impression that weather was some special case, but it looks like I can't see why this would negatively impact other conditions, like cloud.

I had a look through the data paying attentions to cloud and weather to see if we could take this approach, and it looks like it'd be fine to do.

Also, it seems my previous assumption about weather being updated only every 3 hours is incorrect - there are some extra readings in there where it looks like the condition changed prematurely, so this is good reason to forego the update interval change.

{"local_date_time":"02/07:00am","weather":"-","cloud":"-","cloud_base_m":null,"cloud_oktas":null,"cloud_type_id":null,"cloud_type":"-"} {"local_date_time":"02/06:30am","weather":"-","cloud":"-","cloud_base_m":null,"cloud_oktas":null,"cloud_type_id":null,"cloud_type":"-"} {"local_date_time":"02/06:00am","weather":"Fine","cloud":"Mostly cloudy","cloud_base_m":2500,"cloud_oktas":7,"cloud_type_id":30,"cloud_type":"-"} {"local_date_time":"02/05:30am","weather":"-","cloud":"-","cloud_base_m":null,"cloud_oktas":null,"cloud_type_id":null,"cloud_type":"-"} {"local_date_time":"02/05:00am","weather":"-","cloud":"-","cloud_base_m":null,"cloud_oktas":null,"cloud_type_id":null,"cloud_type":"-"} {"local_date_time":"02/04:30am","weather":"-","cloud":"-","cloud_base_m":null,"cloud_oktas":null,"cloud_type_id":null,"cloud_type":"-"} {"local_date_time":"02/04:00am","weather":"-","cloud":"-","cloud_base_m":null,"cloud_oktas":null,"cloud_type_id":null,"cloud_type":"-"} {"local_date_time":"02/03:30am","weather":"-","cloud":"-","cloud_base_m":null,"cloud_oktas":null,"cloud_type_id":null,"cloud_type":"-"} {"local_date_time":"02/03:00am","weather":"Fine","cloud":"Mostly cloudy","cloud_base_m":2500,"cloud_oktas":6,"cloud_type_id":30,"cloud_type":"-"} {"local_date_time":"02/02:30am","weather":"-","cloud":"-","cloud_base_m":null,"cloud_oktas":null,"cloud_type_id":null,"cloud_type":"-"} {"local_date_time":"02/02:00am","weather":"-","cloud":"-","cloud_base_m":null,"cloud_oktas":null,"cloud_type_id":null,"cloud_type":"-"} {"local_date_time":"02/01:30am","weather":"-","cloud":"-","cloud_base_m":null,"cloud_oktas":null,"cloud_type_id":null,"cloud_type":"-"} {"local_date_time":"02/01:00am","weather":"-","cloud":"-","cloud_base_m":null,"cloud_oktas":null,"cloud_type_id":null,"cloud_type":"-"} {"local_date_time":"02/12:30am","weather":"-","cloud":"-","cloud_base_m":null,"cloud_oktas":null,"cloud_type_id":null,"cloud_type":"-"} {"local_date_time":"02/12:00am","weather":"Fine","cloud":"Mostly cloudy","cloud_base_m":2500,"cloud_oktas":7,"cloud_type_id":30,"cloud_type":"-"} {"local_date_time":"01/11:30pm","weather":"-","cloud":"-","cloud_base_m":null,"cloud_oktas":null,"cloud_type_id":null,"cloud_type":"-"} {"local_date_time":"01/11:00pm","weather":"-","cloud":"-","cloud_base_m":null,"cloud_oktas":null,"cloud_type_id":null,"cloud_type":"-"} {"local_date_time":"01/10:30pm","weather":"-","cloud":"-","cloud_base_m":null,"cloud_oktas":null,"cloud_type_id":null,"cloud_type":"-"} {"local_date_time":"01/10:00pm","weather":"-","cloud":"-","cloud_base_m":null,"cloud_oktas":null,"cloud_type_id":null,"cloud_type":"-"} {"local_date_time":"01/09:30pm","weather":"-","cloud":"-","cloud_base_m":null,"cloud_oktas":null,"cloud_type_id":null,"cloud_type":"-"} {"local_date_time":"01/09:00pm","weather":"Fine","cloud":"Partly cloudy","cloud_base_m":2500,"cloud_oktas":4,"cloud_type_id":30,"cloud_type":"-"} {"local_date_time":"01/08:30pm","weather":"-","cloud":"-","cloud_base_m":null,"cloud_oktas":null,"cloud_type_id":null,"cloud_type":"-"} {"local_date_time":"01/08:00pm","weather":"-","cloud":"-","cloud_base_m":null,"cloud_oktas":null,"cloud_type_id":null,"cloud_type":"-"} {"local_date_time":"01/07:30pm","weather":"-","cloud":"-","cloud_base_m":null,"cloud_oktas":null,"cloud_type_id":null,"cloud_type":"-"} {"local_date_time":"01/07:00pm","weather":"-","cloud":"-","cloud_base_m":null,"cloud_oktas":null,"cloud_type_id":null,"cloud_type":"-"} {"local_date_time":"01/06:30pm","weather":"-","cloud":"-","cloud_base_m":null,"cloud_oktas":null,"cloud_type_id":null,"cloud_type":"-"} {"local_date_time":"01/06:00pm","weather":"Fine","cloud":"Mostly clear","cloud_base_m":2500,"cloud_oktas":1,"cloud_type_id":30,"cloud_type":"-"} {"local_date_time":"01/05:30pm","weather":"-","cloud":"-","cloud_base_m":null,"cloud_oktas":null,"cloud_type_id":null,"cloud_type":"-"} {"local_date_time":"01/05:00pm","weather":"-","cloud":"-","cloud_base_m":null,"cloud_oktas":null,"cloud_type_id":null,"cloud_type":"-"} {"local_date_time":"01/04:30pm","weather":"-","cloud":"-","cloud_base_m":null,"cloud_oktas":null,"cloud_type_id":null,"cloud_type":"-"} {"local_date_time":"01/04:00pm","weather":"-","cloud":"-","cloud_base_m":null,"cloud_oktas":null,"cloud_type_id":null,"cloud_type":"-"} {"local_date_time":"01/03:30pm","weather":"-","cloud":"-","cloud_base_m":null,"cloud_oktas":null,"cloud_type_id":null,"cloud_type":"-"} {"local_date_time":"01/03:00pm","weather":"Fine","cloud":"Mostly clear","cloud_base_m":2500,"cloud_oktas":1,"cloud_type_id":30,"cloud_type":"-"} {"local_date_time":"01/02:30pm","weather":"-","cloud":"-","cloud_base_m":null,"cloud_oktas":null,"cloud_type_id":null,"cloud_type":"-"} {"local_date_time":"01/02:00pm","weather":"-","cloud":"-","cloud_base_m":null,"cloud_oktas":null,"cloud_type_id":null,"cloud_type":"-"} {"local_date_time":"01/01:30pm","weather":"-","cloud":"-","cloud_base_m":null,"cloud_oktas":null,"cloud_type_id":null,"cloud_type":"-"} {"local_date_time":"01/01:00pm","weather":"-","cloud":"-","cloud_base_m":null,"cloud_oktas":null,"cloud_type_id":null,"cloud_type":"-"} {"local_date_time":"01/12:30pm","weather":"-","cloud":"-","cloud_base_m":null,"cloud_oktas":null,"cloud_type_id":null,"cloud_type":"-"} {"local_date_time":"01/12:00pm","weather":"Fine","cloud":"Mostly clear","cloud_base_m":2500,"cloud_oktas":1,"cloud_type_id":30,"cloud_type":"-"} {"local_date_time":"01/11:30am","weather":"-","cloud":"-","cloud_base_m":null,"cloud_oktas":null,"cloud_type_id":null,"cloud_type":"-"} {"local_date_time":"01/11:00am","weather":"-","cloud":"-","cloud_base_m":null,"cloud_oktas":null,"cloud_type_id":null,"cloud_type":"-"} {"local_date_time":"01/10:30am","weather":"-","cloud":"-","cloud_base_m":null,"cloud_oktas":null,"cloud_type_id":null,"cloud_type":"-"} {"local_date_time":"01/10:00am","weather":"-","cloud":"Mostly clear","cloud_base_m":1020,"cloud_oktas":1,"cloud_type_id":8,"cloud_type":"Cumulus"} {"local_date_time":"01/09:30am","weather":"-","cloud":"Mostly clear","cloud_base_m":960,"cloud_oktas":1,"cloud_type_id":8,"cloud_type":"Cumulus"} {"local_date_time":"01/09:00am","weather":"Fine","cloud":"Mostly clear","cloud_base_m":600,"cloud_oktas":2,"cloud_type_id":31,"cloud_type":"-"} {"local_date_time":"01/08:30am","weather":"-","cloud":"Mostly clear","cloud_base_m":750,"cloud_oktas":1,"cloud_type_id":8,"cloud_type":"Cumulus"} {"local_date_time":"01/08:00am","weather":"-","cloud":"Mostly clear","cloud_base_m":720,"cloud_oktas":1,"cloud_type_id":8,"cloud_type":"Cumulus"} {"local_date_time":"01/07:30am","weather":"-","cloud":"Mostly clear","cloud_base_m":660,"cloud_oktas":1,"cloud_type_id":8,"cloud_type":"Cumulus"} {"local_date_time":"01/07:00am","weather":"-","cloud":"Mostly clear","cloud_base_m":660,"cloud_oktas":1,"cloud_type_id":8,"cloud_type":"Cumulus"} {"local_date_time":"01/06:30am","weather":"-","cloud":"Mostly clear","cloud_base_m":660,"cloud_oktas":1,"cloud_type_id":8,"cloud_type":"Cumulus"} {"local_date_time":"01/06:00am","weather":"Fine","cloud":"Mostly clear","cloud_base_m":600,"cloud_oktas":1,"cloud_type_id":31,"cloud_type":"-"} {"local_date_time":"01/05:30am","weather":"-","cloud":"Mostly clear","cloud_base_m":600,"cloud_oktas":1,"cloud_type_id":8,"cloud_type":"Cumulus"} {"local_date_time":"01/05:00am","weather":"-","cloud":"-","cloud_base_m":null,"cloud_oktas":null,"cloud_type_id":null,"cloud_type":"-"} {"local_date_time":"01/04:30am","weather":"-","cloud":"-","cloud_base_m":null,"cloud_oktas":null,"cloud_type_id":null,"cloud_type":"-"} {"local_date_time":"01/04:00am","weather":"-","cloud":"-","cloud_base_m":null,"cloud_oktas":null,"cloud_type_id":null,"cloud_type":"-"} {"local_date_time":"01/03:30am","weather":"-","cloud":"-","cloud_base_m":null,"cloud_oktas":null,"cloud_type_id":null,"cloud_type":"-"} {"local_date_time":"01/03:00am","weather":"Fine","cloud":"Clear","cloud_base_m":2500,"cloud_oktas":0,"cloud_type_id":null,"cloud_type":"-"} {"local_date_time":"01/02:30am","weather":"-","cloud":"-","cloud_base_m":null,"cloud_oktas":null,"cloud_type_id":null,"cloud_type":"-"} {"local_date_time":"01/02:00am","weather":"-","cloud":"Mostly clear","cloud_base_m":600,"cloud_oktas":1,"cloud_type_id":8,"cloud_type":"Cumulus"} {"local_date_time":"01/01:30am","weather":"-","cloud":"Mostly clear","cloud_base_m":600,"cloud_oktas":1,"cloud_type_id":8,"cloud_type":"Cumulus"} {"local_date_time":"01/01:00am","weather":"-","cloud":"Mostly clear","cloud_base_m":600,"cloud_oktas":1,"cloud_type_id":8,"cloud_type":"Cumulus"} {"local_date_time":"01/12:30am","weather":"-","cloud":"Mostly clear","cloud_base_m":600,"cloud_oktas":1,"cloud_type_id":8,"cloud_type":"Cumulus"} {"local_date_time":"01/12:00am","weather":"Fine","cloud":"Mostly clear","cloud_base_m":600,"cloud_oktas":1,"cloud_type_id":31,"cloud_type":"-"} {"local_date_time":"30/11:30pm","weather":"-","cloud":"Mostly clear","cloud_base_m":600,"cloud_oktas":1,"cloud_type_id":8,"cloud_type":"Cumulus"} {"local_date_time":"30/11:00pm","weather":"-","cloud":"Mostly clear","cloud_base_m":600,"cloud_oktas":1,"cloud_type_id":8,"cloud_type":"Cumulus"} {"local_date_time":"30/10:30pm","weather":"-","cloud":"Mostly clear","cloud_base_m":600,"cloud_oktas":1,"cloud_type_id":8,"cloud_type":"Cumulus"} {"local_date_time":"30/10:00pm","weather":"-","cloud":"Mostly clear","cloud_base_m":600,"cloud_oktas":1,"cloud_type_id":8,"cloud_type":"Cumulus"} {"local_date_time":"30/09:30pm","weather":"-","cloud":"Mostly clear","cloud_base_m":600,"cloud_oktas":1,"cloud_type_id":8,"cloud_type":"Cumulus"} {"local_date_time":"30/09:00pm","weather":"Fine","cloud":"Mostly clear","cloud_base_m":600,"cloud_oktas":1,"cloud_type_id":31,"cloud_type":"-"} {"local_date_time":"30/08:30pm","weather":"-","cloud":"Mostly clear","cloud_base_m":600,"cloud_oktas":1,"cloud_type_id":8,"cloud_type":"Cumulus"} {"local_date_time":"30/08:00pm","weather":"-","cloud":"Mostly clear","cloud_base_m":600,"cloud_oktas":1,"cloud_type_id":8,"cloud_type":"Cumulus"} {"local_date_time":"30/07:30pm","weather":"-","cloud":"Mostly clear","cloud_base_m":540,"cloud_oktas":1,"cloud_type_id":8,"cloud_type":"Cumulus"} {"local_date_time":"30/07:00pm","weather":"-","cloud":"Mostly clear","cloud_base_m":540,"cloud_oktas":1,"cloud_type_id":8,"cloud_type":"Cumulus"} {"local_date_time":"30/06:30pm","weather":"-","cloud":"Mostly clear","cloud_base_m":540,"cloud_oktas":1,"cloud_type_id":8,"cloud_type":"Cumulus"} {"local_date_time":"30/06:00pm","weather":"Distant precip.","cloud":"Mostly clear","cloud_base_m":300,"cloud_oktas":1,"cloud_type_id":38,"cloud_type":"-"} {"local_date_time":"30/05:30pm","weather":"-","cloud":"Mostly clear","cloud_base_m":540,"cloud_oktas":1,"cloud_type_id":7,"cloud_type":"Stratus"} {"local_date_time":"30/05:00pm","weather":"-","cloud":"Mostly clear","cloud_base_m":540,"cloud_oktas":1,"cloud_type_id":7,"cloud_type":"Stratus"} {"local_date_time":"30/04:30pm","weather":"-","cloud":"Mostly clear","cloud_base_m":540,"cloud_oktas":1,"cloud_type_id":7,"cloud_type":"Stratus"} {"local_date_time":"30/04:00pm","weather":"-","cloud":"Mostly clear","cloud_base_m":750,"cloud_oktas":2,"cloud_type_id":8,"cloud_type":"Cumulus"} {"local_date_time":"30/03:30pm","weather":"-","cloud":"Mostly clear","cloud_base_m":540,"cloud_oktas":1,"cloud_type_id":7,"cloud_type":"Stratus"} {"local_date_time":"30/03:00pm","weather":"Distant precip.","cloud":"Partly cloudy","cloud_base_m":600,"cloud_oktas":5,"cloud_type_id":38,"cloud_type":"-"} {"local_date_time":"30/02:30pm","weather":"-","cloud":"Mostly clear","cloud_base_m":750,"cloud_oktas":1,"cloud_type_id":8,"cloud_type":"Cumulus"} {"local_date_time":"30/02:00pm","weather":"-","cloud":"Mostly clear","cloud_base_m":750,"cloud_oktas":1,"cloud_type_id":8,"cloud_type":"Cumulus"} {"local_date_time":"30/01:30pm","weather":"-","cloud":"Mostly clear","cloud_base_m":660,"cloud_oktas":1,"cloud_type_id":8,"cloud_type":"Cumulus"} {"local_date_time":"30/01:00pm","weather":"-","cloud":"Mostly clear","cloud_base_m":660,"cloud_oktas":1,"cloud_type_id":8,"cloud_type":"Cumulus"} {"local_date_time":"30/12:30pm","weather":"-","cloud":"Mostly clear","cloud_base_m":660,"cloud_oktas":1,"cloud_type_id":8,"cloud_type":"Cumulus"} {"local_date_time":"30/12:00pm","weather":"Distant precip.","cloud":"Partly cloudy","cloud_base_m":600,"cloud_oktas":5,"cloud_type_id":38,"cloud_type":"-"} {"local_date_time":"30/11:30am","weather":"-","cloud":"Partly cloudy","cloud_base_m":810,"cloud_oktas":3,"cloud_type_id":8,"cloud_type":"Cumulus"} {"local_date_time":"30/11:00am","weather":"-","cloud":"Partly cloudy","cloud_base_m":810,"cloud_oktas":3,"cloud_type_id":8,"cloud_type":"Cumulus"} {"local_date_time":"30/10:30am","weather":"-","cloud":"Mostly clear","cloud_base_m":750,"cloud_oktas":2,"cloud_type_id":8,"cloud_type":"Cumulus"} {"local_date_time":"30/10:00am","weather":"-","cloud":"Mostly clear","cloud_base_m":450,"cloud_oktas":1,"cloud_type_id":7,"cloud_type":"Stratus"} {"local_date_time":"30/09:30am","weather":"-","cloud":"Partly cloudy","cloud_base_m":810,"cloud_oktas":3,"cloud_type_id":8,"cloud_type":"Cumulus"} {"local_date_time":"30/09:00am","weather":"Distant precip.","cloud":"Partly cloudy","cloud_base_m":600,"cloud_oktas":4,"cloud_type_id":38,"cloud_type":"-"} {"local_date_time":"30/08:30am","weather":"-","cloud":"Mostly clear","cloud_base_m":450,"cloud_oktas":1,"cloud_type_id":7,"cloud_type":"Stratus"} {"local_date_time":"30/08:00am","weather":"-","cloud":"Mostly clear","cloud_base_m":450,"cloud_oktas":1,"cloud_type_id":7,"cloud_type":"Stratus"} {"local_date_time":"30/07:30am","weather":"Showers","cloud":"Mostly clear","cloud_base_m":450,"cloud_oktas":1,"cloud_type_id":7,"cloud_type":"Stratus"} {"local_date_time":"30/07:00am","weather":"-","cloud":"Mostly clear","cloud_base_m":540,"cloud_oktas":1,"cloud_type_id":8,"cloud_type":"Cumulus"} {"local_date_time":"30/06:30am","weather":"-","cloud":"Mostly clear","cloud_base_m":540,"cloud_oktas":1,"cloud_type_id":8,"cloud_type":"Cumulus"} {"local_date_time":"30/06:00am","weather":"Distant precip.","cloud":"Partly cloudy","cloud_base_m":300,"cloud_oktas":3,"cloud_type_id":38,"cloud_type":"-"} {"local_date_time":"30/05:30am","weather":"-","cloud":"Mostly clear","cloud_base_m":540,"cloud_oktas":1,"cloud_type_id":8,"cloud_type":"Cumulus"} {"local_date_time":"30/05:00am","weather":"-","cloud":"Mostly clear","cloud_base_m":540,"cloud_oktas":1,"cloud_type_id":8,"cloud_type":"Cumulus"} {"local_date_time":"30/04:30am","weather":"-","cloud":"Mostly clear","cloud_base_m":600,"cloud_oktas":1,"cloud_type_id":8,"cloud_type":"Cumulus"} {"local_date_time":"30/04:00am","weather":"-","cloud":"Mostly clear","cloud_base_m":360,"cloud_oktas":1,"cloud_type_id":7,"cloud_type":"Stratus"} {"local_date_time":"30/03:30am","weather":"-","cloud":"Mostly clear","cloud_base_m":720,"cloud_oktas":1,"cloud_type_id":8,"cloud_type":"Cumulus"} {"local_date_time":"30/03:00am","weather":"Recent precip.","cloud":"Partly cloudy","cloud_base_m":300,"cloud_oktas":5,"cloud_type_id":38,"cloud_type":"-"} {"local_date_time":"30/02:30am","weather":"Showers","cloud":"Mostly clear","cloud_base_m":360,"cloud_oktas":1,"cloud_type_id":7,"cloud_type":"Stratus"} {"local_date_time":"30/02:20am","weather":"Showers","cloud":"Mostly clear","cloud_base_m":360,"cloud_oktas":1,"cloud_type_id":7,"cloud_type":"Stratus"} {"local_date_time":"30/02:00am","weather":"-","cloud":"Mostly clear","cloud_base_m":360,"cloud_oktas":1,"cloud_type_id":7,"cloud_type":"Stratus"} {"local_date_time":"30/01:30am","weather":"-","cloud":"Mostly clear","cloud_base_m":840,"cloud_oktas":1,"cloud_type_id":8,"cloud_type":"Cumulus"} {"local_date_time":"30/01:00am","weather":"-","cloud":"Mostly clear","cloud_base_m":450,"cloud_oktas":1,"cloud_type_id":7,"cloud_type":"Stratus"} {"local_date_time":"30/12:30am","weather":"-","cloud":"Mostly clear","cloud_base_m":840,"cloud_oktas":1,"cloud_type_id":8,"cloud_type":"Cumulus"} {"local_date_time":"30/12:00am","weather":"Recent precip.","cloud":"Mostly cloudy","cloud_base_m":600,"cloud_oktas":7,"cloud_type_id":38,"cloud_type":"-"} {"local_date_time":"29/11:30pm","weather":"-","cloud":"Mostly clear","cloud_base_m":750,"cloud_oktas":1,"cloud_type_id":8,"cloud_type":"Cumulus"} {"local_date_time":"29/11:00pm","weather":"-","cloud":"Mostly clear","cloud_base_m":840,"cloud_oktas":1,"cloud_type_id":8,"cloud_type":"Cumulus"} {"local_date_time":"29/10:30pm","weather":"Thunder","cloud":"Mostly clear","cloud_base_m":360,"cloud_oktas":1,"cloud_type_id":7,"cloud_type":"Stratus"} {"local_date_time":"29/10:15pm","weather":"Thunderstorm","cloud":"Mostly clear","cloud_base_m":360,"cloud_oktas":1,"cloud_type_id":7,"cloud_type":"Stratus"} {"local_date_time":"29/10:00pm","weather":"-","cloud":"Mostly clear","cloud_base_m":360,"cloud_oktas":1,"cloud_type_id":7,"cloud_type":"Stratus"} {"local_date_time":"29/09:53pm","weather":"Showers","cloud":"Mostly clear","cloud_base_m":450,"cloud_oktas":1,"cloud_type_id":7,"cloud_type":"Stratus"} {"local_date_time":"29/09:30pm","weather":"Showers","cloud":"Mostly clear","cloud_base_m":300,"cloud_oktas":2,"cloud_type_id":7,"cloud_type":"Stratus"} {"local_date_time":"29/09:00pm","weather":"Thunderstorm","cloud":"Mostly cloudy","cloud_base_m":300,"cloud_oktas":7,"cloud_type_id":39,"cloud_type":"-"} {"local_date_time":"29/08:53pm","weather":"Thunderstorm","cloud":"Mostly clear","cloud_base_m":450,"cloud_oktas":1,"cloud_type_id":7,"cloud_type":"Stratus"} {"local_date_time":"29/08:30pm","weather":"-","cloud":"Mostly clear","cloud_base_m":780,"cloud_oktas":2,"cloud_type_id":8,"cloud_type":"Cumulus"} {"local_date_time":"29/08:00pm","weather":"-","cloud":"Mostly clear","cloud_base_m":750,"cloud_oktas":1,"cloud_type_id":8,"cloud_type":"Cumulus"} {"local_date_time":"29/07:30pm","weather":"-","cloud":"Mostly clear","cloud_base_m":750,"cloud_oktas":1,"cloud_type_id":8,"cloud_type":"Cumulus"} {"local_date_time":"29/07:00pm","weather":"-","cloud":"Mostly clear","cloud_base_m":750,"cloud_oktas":1,"cloud_type_id":8,"cloud_type":"Cumulus"} {"local_date_time":"29/06:30pm","weather":"-","cloud":"Mostly clear","cloud_base_m":750,"cloud_oktas":1,"cloud_type_id":8,"cloud_type":"Cumulus"} {"local_date_time":"29/06:00pm","weather":"Distant precip.","cloud":"Mostly clear","cloud_base_m":600,"cloud_oktas":2,"cloud_type_id":38,"cloud_type":"-"} {"local_date_time":"29/05:30pm","weather":"-","cloud":"Mostly clear","cloud_base_m":750,"cloud_oktas":1,"cloud_type_id":8,"cloud_type":"Cumulus"} {"local_date_time":"29/05:00pm","weather":"-","cloud":"Mostly clear","cloud_base_m":900,"cloud_oktas":1,"cloud_type_id":8,"cloud_type":"Cumulus"} {"local_date_time":"29/04:30pm","weather":"-","cloud":"Mostly clear","cloud_base_m":750,"cloud_oktas":1,"cloud_type_id":8,"cloud_type":"Cumulus"} {"local_date_time":"29/04:00pm","weather":"-","cloud":"Mostly clear","cloud_base_m":900,"cloud_oktas":1,"cloud_type_id":8,"cloud_type":"Cumulus"} {"local_date_time":"29/03:30pm","weather":"-","cloud":"Mostly clear","cloud_base_m":900,"cloud_oktas":1,"cloud_type_id":8,"cloud_type":"Cumulus"} {"local_date_time":"29/03:00pm","weather":"Fine","cloud":"Mostly cloudy","cloud_base_m":600,"cloud_oktas":7,"cloud_type_id":38,"cloud_type":"-"} {"local_date_time":"29/02:30pm","weather":"-","cloud":"Mostly clear","cloud_base_m":900,"cloud_oktas":1,"cloud_type_id":8,"cloud_type":"Cumulus"} {"local_date_time":"29/02:00pm","weather":"-","cloud":"Mostly clear","cloud_base_m":900,"cloud_oktas":1,"cloud_type_id":8,"cloud_type":"Cumulus"} {"local_date_time":"29/01:30pm","weather":"-","cloud":"Mostly clear","cloud_base_m":900,"cloud_oktas":1,"cloud_type_id":8,"cloud_type":"Cumulus"} {"local_date_time":"29/01:00pm","weather":"-","cloud":"Mostly clear","cloud_base_m":900,"cloud_oktas":1,"cloud_type_id":8,"cloud_type":"Cumulus"} {"local_date_time":"29/12:30pm","weather":"-","cloud":"Mostly clear","cloud_base_m":900,"cloud_oktas":1,"cloud_type_id":8,"cloud_type":"Cumulus"} {"local_date_time":"29/12:00pm","weather":"Fine","cloud":"Mostly cloudy","cloud_base_m":600,"cloud_oktas":6,"cloud_type_id":38,"cloud_type":"-"} {"local_date_time":"29/11:30am","weather":"-","cloud":"Mostly clear","cloud_base_m":900,"cloud_oktas":1,"cloud_type_id":8,"cloud_type":"Cumulus"} {"local_date_time":"29/11:00am","weather":"-","cloud":"Mostly clear","cloud_base_m":900,"cloud_oktas":1,"cloud_type_id":8,"cloud_type":"Cumulus"} {"local_date_time":"29/10:36am","weather":"-","cloud":"Mostly clear","cloud_base_m":900,"cloud_oktas":1,"cloud_type_id":8,"cloud_type":"Cumulus"} {"local_date_time":"29/10:30am","weather":"-","cloud":"Mostly clear","cloud_base_m":900,"cloud_oktas":1,"cloud_type_id":8,"cloud_type":"Cumulus"} {"local_date_time":"29/10:00am","weather":"-","cloud":"Mostly clear","cloud_base_m":900,"cloud_oktas":1,"cloud_type_id":8,"cloud_type":"Cumulus"} {"local_date_time":"29/09:30am","weather":"-","cloud":"Mostly clear","cloud_base_m":750,"cloud_oktas":1,"cloud_type_id":8,"cloud_type":"Cumulus"} {"local_date_time":"29/09:00am","weather":"Fine","cloud":"Partly cloudy","cloud_base_m":600,"cloud_oktas":3,"cloud_type_id":38,"cloud_type":"-"} {"local_date_time":"29/08:30am","weather":"-","cloud":"Mostly clear","cloud_base_m":750,"cloud_oktas":1,"cloud_type_id":8,"cloud_type":"Cumulus"} {"local_date_time":"29/08:00am","weather":"-","cloud":"Mostly clear","cloud_base_m":750,"cloud_oktas":1,"cloud_type_id":8,"cloud_type":"Cumulus"} {"local_date_time":"29/07:30am","weather":"Showers","cloud":"Mostly clear","cloud_base_m":750,"cloud_oktas":1,"cloud_type_id":8,"cloud_type":"Cumulus"}

houndci-bot · 2018-05-08T07:17:22Z

line too long (81 > 79 characters)

nickw444 · 2018-05-08T10:08:20Z

Hey @OttoWinter changes are up, and I rebased onto dev.

homeassistant added cla-signed platform: weather.bom labels Apr 22, 2018

houndci-bot reviewed Apr 22, 2018

View reviewed changes

homeassistant added the cla-signed label Apr 22, 2018

OttoWinter reviewed Apr 22, 2018

View reviewed changes

houndci-bot reviewed Apr 22, 2018

View reviewed changes

OttoWinter reviewed May 1, 2018

View reviewed changes

nickw444 force-pushed the nwhyte/bom-weather-improvement branch from 5440b2e to 2f6b1ed Compare May 1, 2018 21:56

homeassistant added the cla-signed label May 1, 2018

nickw444 mentioned this pull request May 1, 2018

BOM Weather throttle fix #14234

Merged

2 tasks

nickw444 force-pushed the nwhyte/bom-weather-improvement branch from 2f6b1ed to 87fbc7e Compare May 8, 2018 07:17

homeassistant added the cla-signed label May 8, 2018

houndci-bot reviewed May 8, 2018

View reviewed changes

Comment thread homeassistant/components/weather/bom.py Outdated

Copy link
Copy Markdown

houndci-bot May 8, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

line too long (81 > 79 characters)

Fix BOM weather '-' value

cd238bf

nickw444 force-pushed the nwhyte/bom-weather-improvement branch from 87fbc7e to cd238bf Compare May 8, 2018 07:20

homeassistant added the cla-signed label May 8, 2018

balloob merged commit e12994a into home-assistant:dev May 8, 2018

balloob mentioned this pull request May 28, 2018

0.70.0 #14657

Merged

girlpunk pushed a commit to girlpunk/home-assistant that referenced this pull request Sep 4, 2018

Fix BOM weather '-' value (home-assistant#14042)

3ee0b70

home-assistant locked and limited conversation to collaborators Sep 5, 2018

ghost added integration: bom and removed platform: sensor.bom labels Mar 21, 2019

Uh oh!

Conversation

nickw444 commented Apr 22, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description:

Example entry for configuration.yaml (if applicable):

Checklist:

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

nickw444 Apr 22, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

balloob commented Apr 22, 2018

Uh oh!

nickw444 commented Apr 22, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

balloob commented Apr 23, 2018

Uh oh!

nickw444 commented Apr 23, 2018

1. What if BOM changes the update interval?

2. What about other conditions like current temperature?

Uh oh!

nickw444 commented Apr 30, 2018

Uh oh!

OttoWinter left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

nickw444 May 1, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

nickw444 commented May 8, 2018

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

nickw444 commented Apr 22, 2018 •

edited

Loading

Example entry for `configuration.yaml` (if applicable):

nickw444 Apr 22, 2018 •

edited

Loading

nickw444 commented Apr 22, 2018 •

edited

Loading

nickw444 May 1, 2018 •

edited

Loading