Skip to content

Expose the condition code on condition sensors #14011

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
MartinHjelmare merged 5 commits into from
Apr 21, 2018
Merged

Expose the condition code on condition sensors #14011

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
a9bf32e
expose the condition code on condition sensors
maddox Apr 20, 2018
f897663
:lipstick:
maddox Apr 20, 2018
49aa7de
like thisss duh
maddox Apr 20, 2018
5824919
add test for condition_code
maddox Apr 20, 2018
f705a15
It’s a string
maddox Apr 20, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 6 additions & 3 deletions homeassistant/components/sensor/yweather.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -131,9 +131,12 @@ def entity_picture(self):
@property
def device_state_attributes(self):
"""Return the state attributes."""
return {
ATTR_ATTRIBUTION: CONF_ATTRIBUTION,
}
attrs = { ATTR_ATTRIBUTION: CONF_ATTRIBUTION }

@houndci-bot houndci-bot Apr 20, 2018

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

whitespace after '{'
whitespace before '}'


if self._code is None or "weather" in self._type:

@syssi syssi Apr 20, 2018

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should the attribute added always (attrs['condition_code'] = None) even if "weather" isn't in self._type?

@maddox maddox Apr 20, 2018

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No. Only the weather condition version of this sensor should have condition code since it doesn’t make much sense for the temp sensor to have it.

This follows the pattern of entity_image

@balloob balloob Apr 20, 2018

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you want to follow that pattern, you should check for is not None

@maddox maddox Apr 20, 2018

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, I blew this, copying the pattern for returning None lol. Late night PRs.

I’ll fix it later today. Thanks.

attrs['condition_code'] = self._code

return attrs

def update(self):
"""Get the latest data from Yahoo! and updates the states."""
Expand Down