deCONZ use forward entry setup

[Kane610]

Description:

Checklist:

• The code change is tested and works locally.
• Local tests pass with tox. Your PR cannot be merged unless tests pass

If the code does not interact with devices:

• Tests have been added to verify that the new code works.

[Kane610]

@balloob just a quick check I'm not doing something different from how you want it. Also, are tests expected for the platforms and deconz setup?

[balloob]

Writing auth credentials to the log

[Kane610]

There are a couple of places in the lib that also happens, but only when enabling debug. Another issue is that all communication is http only.

[balloob]

Any reason this is a standalone method and not just part of async_setup_entry ?

[Kane610]

Only legacy reasons, which are now irrelevant. Thanks for pointing that out!

[balloob]

Yes this seems right.

And yes, everything that has to do with config entries or entity registry requires full test coverage.

[MartinHjelmare]

For another PR we should check in entity platform helper if the platform has setup_platform attribute, and only then call that. Then we can remove these functions from platforms that don't need them and are set up via config entry forwarding.

[houndci-bot]

redefinition of unused 'test_setup_entry_already_registered_bridge' from line 71

[balloob]

Make sure to remove the WIP from the title when it's ready for review.

[Kane610]

@balloob it's the tests that are left. Trying to figure stuff out. Would help if you could hint me in the right direction.

I'm trying to figure out how to patch/mock the pydeconz class and methods since they only need to return true or false with async setup entry

[houndci-bot]

too many blank lines (2)

[houndci-bot]

line too long (86 > 79 characters)

[houndci-bot]

expected 2 blank lines, found 1

[houndci-bot]

line too long (83 > 79 characters)

[Kane610]

@balloob I feel like this is ready for a review now

[balloob]

Awesome!

[Kane610]

Great @balloob !