Skip to content

Added snips service descriptions#13883

Merged
fabaff merged 2 commits intohome-assistant:devfrom
todschmidt:snips-service-string
Apr 14, 2018
Merged

Added snips service descriptions#13883
fabaff merged 2 commits intohome-assistant:devfrom
todschmidt:snips-service-string

Conversation

@todschmidt
Copy link
Copy Markdown
Contributor

@todschmidt todschmidt commented Apr 14, 2018

Description:

Related issue (if applicable): fixes # N/A
Pull request in home-assistant.github.io with documentation (if applicable): home-assistant/home-assistant.github.io#N/A

Example entry for configuration.yaml (if applicable):

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • New dependencies have been added to the REQUIREMENTS variable (example).
  • New dependencies are only imported inside functions that use them (example).
  • New dependencies have been added to requirements_all.txt by running script/gen_requirements_all.py.
  • New files were added to .coveragerc.

If the code does not interact with devices:

  • Tests have been added to verify that the new code works.

@fabaff fabaff changed the title TINY PR: Added snips service descriptions. Added snips service descriptions Apr 14, 2018
Copy link
Copy Markdown
Member

@fabaff fabaff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 🐦

@fabaff fabaff merged commit 1c4da0c into home-assistant:dev Apr 14, 2018
pvizeli added a commit that referenced this pull request Apr 15, 2018
pvizeli added a commit that referenced this pull request Apr 15, 2018
* Revert "Add unique_id for BMW ConnectedDrive (#13888)"

This reverts commit 9014e26.

* Revert "Added snips service descriptions (#13883)"

This reverts commit 1c4da0c.

* Revert "Fix race condition for component loaded before listening (#13887)"

This reverts commit bba997e.

* Revert "Missing property decorator added (#13889)"

This reverts commit bf98b79.

* Revert "Update frontend to 20180414.0"

This reverts commit 1617fbe.

* Revert "Further untangle data entry flow (#13855)"

This reverts commit 4d44c0f.

* Revert "add support for Kodi discovery (#13790)"

This reverts commit 5a5dad6.

* Revert "Update yweather.py (#13851)"

This reverts commit c3388d6.
@balloob balloob mentioned this pull request Apr 27, 2018
@home-assistant home-assistant locked and limited conversation to collaborators Jul 26, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants