Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add authentication to error log endpoint #13836

Merged
merged 1 commit into from
Apr 13, 2018
Merged

Add authentication to error log endpoint #13836

merged 1 commit into from
Apr 13, 2018

Conversation

balloob
Copy link
Member

@balloob balloob commented Apr 12, 2018

Description:

Require authentication when fetching the raw error log.

Does not require a frontend change as frontend already calls API using auth.

Related issue (if applicable): Reported by Matt Hamilton.

Example entry for configuration.yaml (if applicable):

api:

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass

If the code does not interact with devices:

  • Tests have been added to verify that the new code works.

@balloob balloob added this to the 0.67 milestone Apr 12, 2018
@balloob balloob requested a review from a team as a code owner April 12, 2018 15:39
@pvizeli pvizeli merged commit 20ababe into dev Apr 13, 2018
@pvizeli pvizeli deleted the auth-error-log branch April 13, 2018 11:32
@pvizeli
Copy link
Member

pvizeli commented Apr 13, 2018

Yeah that is a security issue

@Eriner
Copy link
Contributor

Eriner commented Apr 13, 2018

Thanks for the quick response and resolution @balloob!

@balloob balloob mentioned this pull request Apr 13, 2018
@home-assistant home-assistant locked and limited conversation to collaborators Jul 26, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants