Energyid integration#138206
Conversation
![home-assistant[bot]](https://avatars.githubusercontent.com/in/97978?s=60&v=4){kind=small}
home-assistant
Bot
added
cla-recheck
cla-signed
and removed
cla-recheck
cla-needed
labels
Molier
force-pushed
the
energyid-webhooks
branch
from
df2ce9c to
0080dff
Compare
zweckj
left a comment
zweckj
left a comment
There was a problem hiding this comment.
Hi, thanks for your contribution 👋
So
- why would I want to sent something from my HA instance somewhere? Can you please explain a bit more about the use-case and what data/entities would be supported?
- The library code is not properly linked in mypy and doesn't use tagged releases which are pushed using CI (which we required)
- If we are building an integration that doesn't have any entities but only provides services we should implement, well, proper services (in services.py with a services.yaml, which are added in async_setup)
|
Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍 |
|
JrtPec
left a comment
JrtPec
left a comment
There was a problem hiding this comment.
I have tested the integration and could successfully upload sensor data to EnergyID!
check ✅
Yes exactly. Type hinting is nice to have and only a requirement for
Exactly what I was thinking about, but now that I understand the use-case a bit better not fitting. So you'd basically select one or multiple entities and the integration would continuously push the updates to the cloud right? In that case a service (action) wouldn't be fitting as those are one time calls triggered by the user |
Molier
force-pushed
the
energyid-webhooks
branch
from
dbc1830 to
370b310
Compare
|
implemented tagged releases and typing in linked library |
Molier
force-pushed
the
energyid-webhooks
branch
from
6725d23 to
39c40f1
Compare
Yeah, it's a github limitation to prevent bots opening PRs which use CI to do crypto mining 😬 |
|
There are some uncovered lines in To check test coverage locally, run |
…dation - Added tests for polling behavior on authentication errors and connection issues in `test_config_flow.py`. - Implemented validation tests for entity mapping inputs in `test_energyid_sensor_mapping_flow.py`. - Enhanced initialization tests in `test_init.py` to cover timeout scenarios, periodic sync errors, and entry unloading with subentries. - Improved error handling in various test cases to ensure robustness against unexpected exceptions and state changes.
…d scenarios. 100 code cov
added tests for full coverage and added some more advanced test for init |
…for sensor mapping
- Verify reauth flows in error scenarios - Add missing assertions and remove redundant tests - Cover polling task cancellation edge cases - Fix missing translations
…o added 1 more assert as suggested
emontnemery
left a comment
emontnemery
left a comment
There was a problem hiding this comment.
This looks good to me now, thanks @Molier 👍
|
Woooohoooo, big up @Molier 😉 And thank you all for the careful overview of this integration! |
8 participants
Breaking change
Proposed change
Introducing the EnergyID integration! EnergyID is an online energy monitoring platform. This integration allows you send sensors from within Home Assistant (eg. energy meters, solar panels, batteries, ...) to your EnergyID-record, using their webhooks.
Some reasons why you would want to upload data (specifically energy measurements) to EnergyID:
As seen before in some threads and git repos (1 , 2) there was some demand for an official integration for data -> EID and not just the other way around.
Type of change
Additional information
Checklist
ruff format homeassistant tests)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest.requirements_all.txt.Updated by running
python3 -m script.gen_requirements_all.To help with the load of incoming pull requests: