Adds support for switch properties in device_state_attributes#13816
Adds support for switch properties in device_state_attributes#13816markperdue wants to merge 1 commit intohome-assistant:devfrom
Conversation
|
@balloob connection state is okay but the other will be to static? |
|
@pvizeli the I added some info to the docs at https://www.home-assistant.io/components/switch.vesync/ that describe the attributes in case it helps |
|
We should not include any model info or other static info. Connection status should also not be part of the attributes but instead be represented as the Note that I also have a vesync PR open because it was doing I/O inside the event loop. Did you never see any warnings related to vesync in your logs? 🤔 #13862 |
|
@balloob Got it. The component is already using the I did not see any warning related to I/O in the hass logs so I thought I was in the clear but nice catch with that. I am running hass in a docker container so I'll investigate around a bit to see how I can add verbosity to the logs to catch that condition. Thanks |
The PR home-assistant/core#13816 has been withdrawn since it exposed static attributes which are not supported. Updating wiki to reflect current state
The PR home-assistant/core#13816 has been withdrawn since it exposed static attributes which are not supported. Updating wiki to reflect current state
Description:
device_state_attributespropertyRelated issue (if applicable): fixes #
Pull request in home-assistant.github.io with documentation (if applicable): home-assistant/home-assistant.io#5151
Checklist:
tox. Your PR cannot be merged unless tests passIf user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
REQUIREMENTSvariable (example).requirements_all.txtby runningscript/gen_requirements_all.py..coveragerc.If the code does not interact with devices: