Support fan/vacuum/media_player as Switch in HomeKit#13805
Support fan/vacuum/media_player as Switch in HomeKit#13805Yonsm wants to merge 2 commits intohome-assistant:devfrom Yonsm:homekit_fan_vacuum_mediaplayer
Conversation
|
I really like the idea of adding those types. However if we just use All of those domains support additional features, that are in part already supported by HomeKit. I'm closing this PR. Each new type should go in a new PR to make reviewing it easier. |
|
Yes, I agree with you. This PR is a temporary and simple support at this moment. Looking forward to support For domain |
|
For If you want, I can open a PR later this week for the |
|
@Yonsm I've done a bit of testing and it seems like HomeKit is quite restrictive about what it supports. Originally I thought that I could add the Their are a few hacks around it, e.g. adding the fan service to control the volume, but I don't think we should go that way. As a result I would follow the solution you suggested earlier to add the For the What's your opinion on it? |
Description:
Support fan/vacuum/media_player as Switch in HomeKit.
Pull request in home-assistant.github.io with documentation (if applicable): home-assistant/home-assistant.github.io#NA If @cdce8p consider this PR is acceptable, I'll update the document in home-assistant.github.io
Checklist:
tox.If user exposed functionality or configuration variables are added/changed:
If the code does not interact with devices: