Improved upgradeability HomeKit type#13783
Merged
cdce8p merged 1 commit intohome-assistant:devfrom Apr 9, 2018
cdce8p:homekit-security_systems-improvement
Merged
Improved upgradeability HomeKit type#13783cdce8p merged 1 commit intohome-assistant:devfrom cdce8p:homekit-security_systems-improvement
cdce8p merged 1 commit intohome-assistant:devfrom
cdce8p:homekit-security_systems-improvement
Conversation
homeassistant
added
integration: homekit
small-pr
cdce8p
changed the title
cdce8p
changed the title
Merged
Adminiuga
pushed a commit
to Adminiuga/home-assistant
that referenced
this pull request
Jun 25, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:
Improved upgradeability for
type_security_systems.py. Using a positive if statement instead of an exclusive one will allow more options to be added later toupdate_state, that depend on an state attribute.Related: #13625 (comment)
Checklist:
tox. Your PR cannot be merged unless tests pass