Device type mapping introduced to avoid breaking change#13765
Merged
pvizeli merged 1 commit intohome-assistant:devfrom Apr 8, 2018
Merged
Device type mapping introduced to avoid breaking change#13765pvizeli merged 1 commit intohome-assistant:devfrom
pvizeli merged 1 commit intohome-assistant:devfrom
Conversation
homeassistant
added
cla-signed
platform: light.yeelight
small-pr
Member
|
Looks good to me, it would be shame to have a breaking change when we can avoid it so easily. Maybe it would still be worth adding a short comment why this is done. |
pvizeli
approved these changes
Apr 8, 2018
Member
|
Type mapping like this will be found on a lot of platform. I think that is legal without comment. |
Merged
ghost
added
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
cp. home-assistant-libs/netdisco#184