Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix LG webOS TV media player test coverage #135225

Merged
merged 3 commits into from
Jan 10, 2025

Conversation

thecode
Copy link
Member

@thecode thecode commented Jan 9, 2025

Proposed change

  • Bring LG webOS TV media player test coverage to 100%
  • Remove WebOsTvPairError from suppress as it already cached inside.
  • Make sure all tests uses FreezeGun and correct async mocks.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Ruff (ruff format homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.

To help with the load of incoming pull requests:

Copy link
Member

@joostlek joostlek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I rather avoid the use of monkeypatch (but thats a personal thing since I never really used it, but also in modern integrations we don't really use it, so I think its better for consistency if we don't use it if possible)

tests/components/webostv/test_media_player.py Outdated Show resolved Hide resolved
@joostlek
Copy link
Member

joostlek commented Jan 9, 2025

Apparently it did work :)

@joostlek joostlek merged commit 9d19891 into home-assistant:dev Jan 10, 2025
34 checks passed
@thecode
Copy link
Member Author

thecode commented Jan 10, 2025

Thanks!

@thecode thecode deleted the webostv-mp-tests branch January 10, 2025 09:47
@github-actions github-actions bot locked and limited conversation to collaborators Jan 11, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants